Skip to content

build: fix python-version selection with actions - #33589

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:workflow
May 29, 2020
Merged

build: fix python-version selection with actions#33589
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:workflow

Conversation

@richardlau

Copy link
Copy Markdown
Member

s/PYTHON_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: #32609

These were missed in #32609.

Checklist

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 27, 2020
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: nodejs#32609
PR-URL: nodejs#33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau

Copy link
Copy Markdown
MemberAuthor

Landed in 69612b7.

@richardlau
richardlau merged commit 69612b7 into nodejs:masterMay 29, 2020
@richardlau
richardlau deleted the workflow branch May 29, 2020 16:53
codebytere pushed a commit that referenced this pull request Jun 18, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@richardlau@jasnell@benjamingr@gengjiawen@BridgeAR@nodejs-github-bot