Uh oh!
There was an error while loading. Please reload this page.
http: refactor agent 'free' handler - #32801
Closed
ronag wants to merge 4 commits into
Closed
Conversation
Remove nesting in favor of early returns.
nodejs-github-bot
commented
Apr 12, 2020
Collaborator
himself65
approved these changes
Apr 13, 2020
lundibundi
approved these changes
Apr 14, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
nodejs-github-bot
commented
Apr 14, 2020
Collaborator
nodejs-github-bot
commented
Apr 14, 2020
Collaborator
nodejs-github-bot
commented
Apr 14, 2020
Collaborator
addaleax
approved these changes
Apr 15, 2020
addaleax
commented
Apr 15, 2020
Member
Landed in 613d421 |
addaleax pushed a commit
that referenced
this pull request
Apr 15, 2020
Remove nesting in favor of early returns. PR-URL: #32801 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2020
Remove nesting in favor of early returns. PR-URL: #32801 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Remove nesting in favor of early returns. PR-URL: #32801 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nesting in favor of early returns.
Ignore whitspace changes for easier review.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes