Skip to content

http: simplify Agent initialization - #33551

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200525-refactor
Closed

http: simplify Agent initialization#33551
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200525-refactor

Conversation

@himself65

@himself65himself65 commented May 25, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 25, 2020
@nodejs-github-bot

nodejs-github-bot commented May 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31550/ 💛 (known flake: parallel/test-http2-reset-flood)

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2020
@lpinca

Copy link
Copy Markdown
Member

Subsystem in commit message should be http: not lib:

@himself65himself65 self-assigned this May 27, 2020
@himself65himself65 changed the title lib: simplify Agent initializationhttp: simplify Agent initializationMay 27, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31600/

himself65 added a commit that referenced this pull request May 28, 2020
PR-URL: #33551
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@himself65

Copy link
Copy Markdown
MemberAuthor

landed in f19a576

@himself65
himself65 deleted the 20200525-refactor branch May 28, 2020 14:21
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33551
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33551
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@codebytere

Copy link
Copy Markdown
Member

Blocked on v12.x for the same reason #32801 is blocked.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@himself65@nodejs-github-bot@lpinca@codebytere@jasnell@addaleax@ronag@BridgeAR@lundibundi@MrHeer