Uh oh!
There was an error while loading. Please reload this page.
stream: update comment to indicate unused API - #32808
Closed
ronag wants to merge 1 commit into
Closed
Conversation
destroy w/ callback was previously used by node core. This is no longer the case and the comments should reflect this to avoid confusion.
ronag
commented
Apr 13, 2020
MemberAuthor
My mistake, there was one last use case I missed. #32809 |
lpinca
approved these changes
Apr 13, 2020
Member
👍 for deprecating it and then removing it. |
ronag
requested review from
AndreasMadsen and mcollina
and removed request for
AndreasMadsenApril 14, 2020 19:37
mcollina
approved these changes
Apr 15, 2020
mcollina
left a comment
Member
There was a problem hiding this comment.
lgtm
I think we could even remove it in a semver-major change.
nodejs-github-bot
commented
Apr 15, 2020
Collaborator
ronag added a commit
to nxtedition/node
that referenced
this pull request
Apr 15, 2020
destroy(err, cb) was an undocumented API which was previously used internally by core modules. However, this is no longer the case and it should be possible to safely remove this. Refs: nodejs#32808
4 tasks
nodejs-github-bot
commented
Apr 15, 2020
Collaborator
nodejs-github-bot
commented
Apr 15, 2020
Collaborator
ronag added a commit
that referenced
this pull request
Apr 16, 2020
destroy w/ callback was previously used by node core. This is no longer the case and the comments should reflect this to avoid confusion. PR-URL: #32808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ronag
commented
Apr 16, 2020
MemberAuthor
Landed in 15cc2b6 |
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2020
destroy w/ callback was previously used by node core. This is no longer the case and the comments should reflect this to avoid confusion. PR-URL: #32808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy w/ callback was previously used by node
core. This is no longer the case and the
comments should reflect this to avoid confusion.
We briefly discussed making this API public. I'm still good with that but it would require the
if (destroyed)branch to usestream.finished. Though if and until then this PR updates the comments to reflect the current state of things. The use ofdestroy(err, cb)has been refactored away in recent PRs.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes