stream: remove unused & undocumented cb

[ronag]

destroy(err, cb) was an undocumented API which
was previously used internally by core modules.
However, this is no longer the case and it should
be possible to safely remove this.

Refs: #32808

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

@nodejs/streams

[vweevers]

I would prefer we add this to the public API. How else can you do asynchronous cleanup?

[ronag]

I would prefer we add this to the public API.

In it's current form it's broken and a correct implementation would pretty much be a shorthand for the example below:

How else can you do asynchronous cleanup?

finished(stream,onDestroyed);stream.destroy();

I'm not opposed to that either. But I think we should either fix it or remove it.

[vweevers]

OK. In that case, LGTM.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30761/

[mcollina]

I think we should do a full deprecation cycle first.

[ronag]

I think we should do a full deprecation cycle first.

Sounds good to me. Close this for now an re-open 15.x:ish? Should we add a runtime deprecation warning?

[mcollina]

I mean, do a runtime deprecation warning in v15 and remove in v16.

[ronag]

Closing in favor of runtime deprecation for v15