Skip to content

src: fix null deref in AllocatedBuffer::clear - #32892

Closed
fowles wants to merge 1 commit into
nodejs:masterfrom
fowles:master
Closed

src: fix null deref in AllocatedBuffer::clear#32892
fowles wants to merge 1 commit into
nodejs:masterfrom
fowles:master

Conversation

@fowles

@fowlesfowles commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@fowles
src: fix null deref in AllocatedBuffer::clear
49f8f01
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 16, 2020
@fowles

fowles commented Apr 16, 2020

Copy link
Copy Markdown
ContributorAuthor

@soldair FYI

@fowlesfowles mentioned this pull request Apr 16, 2020
Closed
2 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30808/

@fowles

fowles commented Apr 17, 2020

Copy link
Copy Markdown
ContributorAuthor

I don't really understand your ci system, but I suspect those are spurious failures

@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30822/

@hybrist

hybrist commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Trying to resume the build, let's see if that's enough.

@fowles

fowles commented Apr 21, 2020

Copy link
Copy Markdown
ContributorAuthor

I think this is ready to merge

@hybristhybrist self-assigned this Apr 21, 2020
hybrist pushed a commit that referenced this pull request Apr 21, 2020
@fowles@hybrist
src: fix null deref in AllocatedBuffer::clear
10cc254
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@hybrist

hybrist commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Landed in 10cc254

@hybristhybrist closed this Apr 21, 2020
@hybristhybrist removed their assignment Apr 21, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@fowles@BethGriggs
src: fix null deref in AllocatedBuffer::clear
4221b1c
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@fowles@BridgeAR
src: fix null deref in AllocatedBuffer::clear
0fdc55f
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@fowles@targos
src: fix null deref in AllocatedBuffer::clear
cbcaf09
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@fowles@targos
src: fix null deref in AllocatedBuffer::clear
cf16cb7
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@hybristhybristhybrist approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@juanarboljuanarboljuanarbol approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fowles@nodejs-github-bot@hybrist@jasnell@addaleax@devnexen@juanarbol