Skip to content

src: fix null deref in AllocatedBuffer::clear - #32893

Closed
fowles wants to merge 1 commit into
nodejs:v12.xfrom
fowles:v12.x
Closed

src: fix null deref in AllocatedBuffer::clear#32893
fowles wants to merge 1 commit into
nodejs:v12.xfrom
fowles:v12.x

Conversation

@fowles

@fowlesfowles commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

Cherry-pick of #32892 to
v12.x branch.

Ref: #32892

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@fowles
src: fix null deref in AllocatedBuffer::clear
41fe422
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v12.x labels Apr 16, 2020
@fowles

fowles commented Apr 16, 2020

Copy link
Copy Markdown
ContributorAuthor

@soldair FYI

@himself65

himself65 commented Apr 17, 2020

Copy link
Copy Markdown
Member

I think you shouldn't pr to v12 branch, only master branch is ok

@addaleax

addaleax commented Apr 17, 2020

Copy link
Copy Markdown
Member

Yes, unless the change only applies to v12.x, PRs go into master first. Unless there is a reason not to, they will be backported to LTS release lines, too. I’ll close this, as #32892 already takes care of everything here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fowles@himself65@addaleax@nodejs-github-bot