Uh oh!
There was an error while loading. Please reload this page.
deps: update http_parser to 2.4.0 - #345
Conversation
yosuke-furukawa
commented
Jan 13, 2015
+1 !!! Thanks for quick release. |
rvagg
commented
Jan 14, 2015
+1 just for the how safe is this to land straight into 1.0.0 @indutny? I don't have a feel for how major (and potentially dangerous) these changes are. |
indutny
commented
Jan 14, 2015
@rvagg I feel safe about it, every commit was reviewed by either me or @bnoordhuis |
rvagg
commented
Jan 14, 2015
ok LGTM then |
PR-URL: #345 Reviewed-By: Rod Vagg <rod@vagg.org>
indutny
commented
Jan 14, 2015
Landed in d790f61, thank you. |
yosuke-furukawa
commented
Jan 14, 2015
I just benchmarked using
machine spec: |
indutny
commented
Jan 14, 2015
Sorry, this is going to be postponed until next release. It breaks build on windows and some tests became flacky (according to users). |
yosuke-furukawa
commented
Jan 14, 2015
hm, no problem. i am looking forward to next release. |
jbergstroem
commented
Jan 14, 2015
Test fail with http_parser 2.4.0 on OS X: |
indutny
commented
Jan 14, 2015
@jbergstroem is it always failing? Appears to be working on my side. |
jbergstroem
commented
Jan 14, 2015
@indutny Just tried once (as well as after pulling the revert). Let me check. Edit: Nope, can't reliably reproduce. |
indutny
commented
Jan 14, 2015
@jbergstroem I think this is just a test problem. I built http-parser with ASAN, and sanitizers for various overflows, and got no errors and no test failures. |
jbergstroem
commented
Jan 14, 2015
@indutny I haven't seen it since; don't take it into consideration until I can give reliable info. |
n/t
cc @bnoordhuis@rvagg