Skip to content

deps: update http_parser to 2.4.0 - #345

Closed
indutny wants to merge 1 commit into
nodejs:v1.xfrom
indutny:feature/update-http_parser-to-2.4
Closed

deps: update http_parser to 2.4.0#345
indutny wants to merge 1 commit into
nodejs:v1.xfrom
indutny:feature/update-http_parser-to-2.4

Conversation

@indutny

Copy link
Copy Markdown
Member

@indutnyindutny added this to the v1.0.0 milestone Jan 13, 2015
@yosuke-furukawa

Copy link
Copy Markdown
Member

+1 !!! Thanks for quick release.

@rvagg

Copy link
Copy Markdown
Member

+1 just for the goto fail additions

how safe is this to land straight into 1.0.0 @indutny? I don't have a feel for how major (and potentially dangerous) these changes are.

@indutny

Copy link
Copy Markdown
MemberAuthor

@rvagg I feel safe about it, every commit was reviewed by either me or @bnoordhuis

@rvagg

Copy link
Copy Markdown
Member

ok LGTM then

indutny added a commit that referenced this pull request Jan 14, 2015
PR-URL: #345
Reviewed-By: Rod Vagg <rod@vagg.org>
@indutny

Copy link
Copy Markdown
MemberAuthor

Landed in d790f61, thank you.

@indutnyindutny closed this Jan 14, 2015
@indutny
indutny deleted the feature/update-http_parser-to-2.4 branch January 14, 2015 00:11
@yosuke-furukawa

Copy link
Copy Markdown
Member

I just benchmarked using benchmark/http.sh .
http is improved! Thanks.

node v0.11.14iojs v1.x brunch(d790f61)
115724.8317600.49
216801.418409.31
317080.6818736.1
417347.1618726.99
516961.3118175.39
616508.4817537.85
717193.6318224.03
817047.3918455.47
917002.9918342.36
1017735.5918652.9
1117559.1318593
1217607.0118704.86
1317159.2718571.3
1417524.8818468.55
1517302.2518570.18
1617604.316193.09
1717684.0315473.57
1817282.9717837.95
1917567.9617696.15
2017471.9617748.02
Average17208.36118035.878

machine spec:
CPU : 2.3 GHz Intel Core i7
Memory : 16GB
OSX Yosemite

@indutny

Copy link
Copy Markdown
MemberAuthor

Sorry, this is going to be postponed until next release. It breaks build on windows and some tests became flacky (according to users).

@yosuke-furukawa

Copy link
Copy Markdown
Member

hm, no problem. i am looking forward to next release.

@jbergstroem

Copy link
Copy Markdown
Member

Test fail with http_parser 2.4.0 on OS X:

=== release test-http-1.0 === Path: parallel/test-http-1.0
assert.js:100
throw new assert.AssertionError({
^
AssertionError: 1 == 2
at response_validator (/private/tmp/io.js/test/parallel/test-http-1.0.js:154:12)
at Socket.<anonymous> (/private/tmp/io.js/test/parallel/test-http-1.0.js:48:7)
at Socket.emit (events.js:117:20)
at _stream_readable.js:888:16
at process._tickCallback (node.js:337:11)
Command: out/Release/iojs /private/tmp/io.js/test/parallel/test-http-1.0.js

@indutny

Copy link
Copy Markdown
MemberAuthor

@jbergstroem is it always failing? Appears to be working on my side.

@jbergstroem

Copy link
Copy Markdown
Member

@indutny Just tried once (as well as after pulling the revert). Let me check.

Edit: Nope, can't reliably reproduce.

@indutny

Copy link
Copy Markdown
MemberAuthor

@jbergstroem I think this is just a test problem. I built http-parser with ASAN, and sanitizers for various overflows, and got no errors and no test failures.

@jbergstroem

Copy link
Copy Markdown
Member

@indutny I haven't seen it since; don't take it into consideration until I can give reliable info.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@indutny@yosuke-furukawa@rvagg@jbergstroem