Skip to content

deps: update http_parser to 2.4.1 - #397

Closed
indutny wants to merge 1 commit into
nodejs:v1.xfrom
indutny:feature/update-http-parser-to-2.4.1
Closed

deps: update http_parser to 2.4.1#397
indutny wants to merge 1 commit into
nodejs:v1.xfrom
indutny:feature/update-http-parser-to-2.4.1

Conversation

@indutny

Copy link
Copy Markdown
Member

@indutny

Copy link
Copy Markdown
MemberAuthor

@indutny

Copy link
Copy Markdown
MemberAuthor

Build does pass now.

@bnoordhuis

Copy link
Copy Markdown
Member

Rubber-stamp LGTM. Did you happen to run the http benchmarks before and after?

indutny added a commit that referenced this pull request Jan 14, 2015
PR-URL: #397
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny

Copy link
Copy Markdown
MemberAuthor

Landed in 598efcb, thank you!

Regarding benchmarks: I didn't, but I seen #345 (comment)

@indutnyindutny closed this Jan 14, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@indutny@bnoordhuis