Skip to content

test: fix flaky http-parser-timeout-reset - #34609

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:timeout-reset-test
Closed

test: fix flaky http-parser-timeout-reset#34609
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:timeout-reset-test

Conversation

@ronag

@ronagronag commented Aug 3, 2020

Copy link
Copy Markdown
Member

Refs: #34578 (comment)

Tries to fix a test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronagronag added the http Issues or PRs related to the http subsystem. label Aug 3, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Aug 3, 2020
@ronag

ronag commented Aug 3, 2020

Copy link
Copy Markdown
MemberAuthor

@richardlau

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 3, 2020
@MylesBorins

Copy link
Copy Markdown
Contributor

we should fast track

@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 3, 2020

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MylesBorins

Copy link
Copy Markdown
Contributor

Landed in 8d8090b

MylesBorins pushed a commit that referenced this pull request Aug 3, 2020
Refs: #34578 (comment)
PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
codebytere pushed a commit that referenced this pull request Aug 6, 2020
Refs: #34578 (comment)
PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@codebyterecodebytere mentioned this pull request Aug 10, 2020
codebytere pushed a commit that referenced this pull request Aug 11, 2020
Refs: #34578 (comment)
PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag@nodejs-github-bot@MylesBorins@richardlau@Flarna