[v12.x backport] http: reset headers timeout on headers complete by orgads · Pull Request #35819 · nodejs/node

orgads · 2020-10-26T16:58:23Z

headers timeout should not occur after headers have been
received.

PR-URL: #34578
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Fedor Indutny fedor.indutny@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Pranshu Srivastava rexagod@gmail.com
(cherry picked from commit da4d8de)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-10-26T16:58:28Z

Review requested:

@nodejs/http
@nodejs/net

orgads · 2020-10-26T17:56:03Z

Looks like another commit is missing?

orgads · 2020-10-26T18:43:00Z

The test passed 1000 as 1e3, which is double, not int32. Probably another commit is missing.

Flarna · 2020-10-26T19:55:11Z

The test passed 1000 as 1e3, which is double, not int32. Probably another commit is missing.

Javascript has only number....

Maybe include #34609 in the backport PR as it fixes something in the test added here.

ronag · 2020-10-26T20:08:14Z

@orgads have you confirmed this actually fixes #35661?

orgads · 2020-10-26T20:11:40Z

The tests pass now (The arguments to parser.initialize are different in 14. I adapted them), and I confirmed it fixes the issue.

Flarna · 2020-10-26T21:30:59Z

The test fails look like that ones fixed by #34609

orgads · 2020-10-26T21:32:32Z

It no longer fails. Unfortunately, the CI keeps running and notifying even after force-push...

orgads · 2020-10-26T21:36:02Z

Oops, didn't notice the bsd tests. Yes, it looks like it. I'll amend.

headers timeout should not occur *after* headers have been received. Fixes: nodejs#35661 PR-URL: nodejs#34578 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> (cherry picked from commit da4d8de)

watilde · 2020-10-27T01:16:48Z

I tested in my local with https://github.com/neversun/node-issue-35661 and this branch works.
@orgads Could you update the target branch to 12.x-staging?

watilde · 2020-10-27T01:18:59Z

~~Let me ask for 👍 to fast track as this PR fixes a regression reported at #35661.~~

cc @nodejs/releasers

richardlau · 2020-10-27T04:45:18Z

Let me ask for 👍 to fast track as this PR fixes a regression reported at #35661.
cc @nodejs/releasers

This needs to be targeted at v12.x-staging and CI rerun (as there are commits there that are not in v12.x.

watilde · 2020-10-27T04:53:23Z

Agreed as I commented the same earlier and I should have arranged that before asking for fast-track. Then I just updated the targeted branch to v12.x-staging and triggered CI again. Once CI gets green light, I'll put fast-track label.

This needs to be targeted at v12.x-staging and CI rerun (as there are commits there that are not in v12.x.

nodejs-github-bot · 2020-10-27T04:56:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33877/

watilde · 2020-10-30T03:10:13Z

I took the fast-track since 48h or more has passed, but I still think this PR remains a high priority as it fixes the regression.

cc @nodejs/releasers

orgads · 2020-11-02T10:22:06Z

What are we waiting for?

watilde · 2020-11-02T10:48:43Z

Let me cc @nodejs/backporters who can land this commit onto the staging branch.

Refs: https://github.com/nodejs/node/blob/7794d36a372b7cb448f5a637765a8fe2e1431d95/doc/guides/collaborator-guide.md#how-are-lts-branches-managed

MylesBorins · 2020-11-02T16:43:42Z

@watilde we'll review this and all 12.x backports before cutting the RC

fwiw fast track isn't necessary for backports as they don't have the same timing requirement as they have previously been reviewed

codebytere · 2020-11-02T21:43:50Z

Landed in 9f3e888

headers timeout should not occur *after* headers have been received. Fixes: #35661 PR-URL: #34578 Backport-PR-URL: #35819 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> (cherry picked from commit da4d8de)

watilde · 2020-11-03T03:24:05Z

@MylesBorins Thank you for letting me know it!

headers timeout should not occur *after* headers have been received. Fixes: #35661 PR-URL: #34578 Backport-PR-URL: #35819 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> (cherry picked from commit da4d8de)

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v12.x labels Oct 26, 2020

orgads changed the title ~~http: reset headers timeout on headers complete~~[v12.x backport] http: reset headers timeout on headers completeOct 26, 2020

orgads mentioned this pull request Oct 26, 2020
HTTP: Connection resets after 60 seconds in node.js upload application #35661
Closed

orgads force-pushed the http-timeout branch from 7782ed9 to e2cc97eCompare October 26, 2020 17:58

orgads force-pushed the http-timeout branch 2 times, most recently from 3225d5d to 9828efdCompare October 26, 2020 19:17

ronag approved these changes Oct 26, 2020
View reviewed changes

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 26, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020

This comment has been minimized.
Sign in to view

Flarna approved these changes Oct 26, 2020
View reviewed changes

orgads force-pushed the http-timeout branch from 9828efd to 0573a69Compare October 26, 2020 21:37

Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020

This comment has been minimized.
Sign in to view

watilde approved these changes Oct 27, 2020
View reviewed changes

watilde changed the base branch from v12.x to v12.x-stagingOctober 27, 2020 04:52

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

rickyes approved these changes Oct 27, 2020
View reviewed changes

watilde added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 27, 2020

fhinkel approved these changes Nov 2, 2020
View reviewed changes

codebytere closed this Nov 2, 2020

orgads deleted the http-timeout branch November 3, 2020 00:34

Uh oh!

Uh oh!

Conversation

orgads commented Oct 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Oct 26, 2020

Uh oh!

orgads commented Oct 26, 2020

Uh oh!

orgads commented Oct 26, 2020

Uh oh!

Flarna commented Oct 26, 2020

Uh oh!

ronag commented Oct 26, 2020

Uh oh!

orgads commented Oct 26, 2020

Uh oh!

This comment has been minimized.

Flarna commented Oct 26, 2020

Uh oh!

orgads commented Oct 26, 2020

Uh oh!

orgads commented Oct 26, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

watilde commented Oct 27, 2020

Uh oh!

watilde commented Oct 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Oct 27, 2020

Uh oh!

watilde commented Oct 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 27, 2020

Uh oh!

watilde commented Oct 30, 2020

Uh oh!

orgads commented Nov 2, 2020

Uh oh!

watilde commented Nov 2, 2020

Uh oh!

MylesBorins commented Nov 2, 2020

Uh oh!

codebytere commented Nov 2, 2020

Uh oh!

watilde commented Nov 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

orgads commented Oct 26, 2020•
edited
Loading

watilde commented Oct 27, 2020•
edited
Loading

watilde commented Oct 27, 2020•
edited
Loading