Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-crypto-pbkdf2 - #35693
Merged
Merged
Conversation
watilde
approved these changes
Oct 17, 2020
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Oct 17, 2020
cjihrig
approved these changes
Oct 17, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Oct 18, 2020
nodejs-github-bot
commented
Oct 18, 2020
Collaborator
PR-URL: nodejs#35693 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trottforce-pushed
the
test-refactor-test-crypto-pbkdf2
branch
from
October 20, 2020 11:58
0a3b260 to
9e227d5CompareTrott
commented
Oct 20, 2020
Member
Landed in 9e227d5 |
BethGriggs pushed a commit
that referenced
this pull request
Oct 21, 2020
PR-URL: #35693 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the test case by introducing a helper function that simply verifies that the sync and async variants produce the same result.
Also,
testPBKDF2did not usemustCall()/mustSucceed(), so it would not fail if the callback was never called.This effectively also changes the loose
mustCall()check at the end of the file to the strictermustSucceed()function.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes