v15.0.1 proposal by BethGriggs · Pull Request #35736 · nodejs/node

BethGriggs · 2020-10-21T11:21:31Z

2020-10-21, Version 15.0.1 (Current), @BethGriggs

Notable changes

crypto: fix regression on randomFillSync (James M Snell) #35723
- This fixes issue crypto: random value issues v15 #35722.
deps: upgrade npm to 7.0.3 (Ruy Adorno) #35724
doc: add release key for Danielle Adams (Danielle Adams) #35545

Commits

[c509485c19] - build: use make functions instead of echo (Antoine du Hamel) #35707
[f5acc2d030] - crypto: fix regression on randomFillSync (James M Snell) #35723
[595c8df48d] - deps: upgrade npm to 7.0.3 (Ruy Adorno) #35724
[69e7f20f2d] - deps: V8: set correct V8 version patch number (Michaël Zasso) #35732
[b78294dc00] - doc: use kbd element in readline doc (Rich Trott) #35698
[1efa87082b] - doc: add release key for Danielle Adams (Danielle Adams) #35545
[6e91d644e3] - doc: use kbd element in os doc (Rich Trott) #35656
[5a48a7b6f8] - doc: add a statement in the documentation. (Pooja D.P) #35585
[6a7a61be7c] - src: mark/pop OpenSSL errors in NewRootCertStore (Daniel Bevenius) #35514
[d54edece99] - test: refactor test-crypto-pbkdf2 (Tobias Nießen) #35693

PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Use kbd element for key strokes and remove extra parentheses. PR-URL: #35656 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

PR-URL: #35693 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Add Danielle Adams's release key. PR-URL: #35545 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #35722 PR-URL: #35723 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

nodejs-github-bot · 2020-10-21T11:21:36Z

Review requested:

@nodejs/crypto

Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (#35723) * This fixes issue #35722. - **doc**: add release key for Danielle Adams (Danielle Adams) (#35545) PR-URL: #35736

nodejs-github-bot · 2020-10-21T11:25:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33775/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3492/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2527/

bricss · 2020-10-21T12:09:17Z

Would be great to pull this #35732 in ➰

codecov-io · 2020-10-21T12:26:31Z

Codecov Report

❗ No coverage uploaded for pull request base (v15.x@df580c5). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## v15.x #35736 +/- ##
========================================
Coverage ? 96.40% ========================================
Files ? 220 Lines ? 73676 Branches ? 0 ========================================
Hits ? 71026 Misses ? 2650 Partials ? 0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df580c5...8451c4a. Read the comment docs.

MylesBorins · 2020-10-21T14:16:00Z

If possible can we include the npm update?
#35724

PR-URL: #35698 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #35707 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This commit sets the OpenSSL error mark before calling X509_STORE_load_locations and pops the error mark afterwards. The motivation for this is that it is possible that X509_STORE_load_locations can produce errors if the configuration option --openssl-system-ca-path file does not exist. Later if a different function is called which calls an OpenSSL function it could fail because these errors might still be on the OpenSSL error stack. Currently, all functions that call NewRootCertStore clear the OpenSSL error queue upon returning, but this was not the case for example in v12.18.0. PR-URL: #35514Fixes: #35456 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: #35732 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

PR-URL: #35724 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (#35723) - This fixes issue #35722. - **deps**: upgrade npm to 7.0.3 (Ruy Adorno) (#35724) - **doc**: add release key for Danielle Adams (Danielle Adams) (#35545) PR-URL: #35736

nodejs-github-bot · 2020-10-21T16:17:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33785/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3500/ ✅

nodejs-github-bot · 2020-10-21T17:47:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33786/ ✅

richardlau

There should be a link to 15.0.1 in the TOC of CHANGELOG_V15.md.

Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (#35723) - This fixes issue #35722. - **deps**: upgrade npm to 7.0.3 (Ruy Adorno) (#35724) - **doc**: add release key for Danielle Adams (Danielle Adams) (#35545) PR-URL: #35736

PR-URL: #35736

Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (#35723) - This fixes issue #35722. - **deps**: upgrade npm to 7.0.3 (Ruy Adorno) (#35724) - **doc**: add release key for Danielle Adams (Danielle Adams) (#35545) PR-URL: #35736

PR-URL: nodejs/node#35736

Refs: nodejs/node#35736

PoojaDurgadand others added 5 commits October 21, 2020 11:17

doc: add a statement in the documentation.
5a48a7b
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

doc: use kbd element in os doc
6e91d64
Use kbd element for key strokes and remove extra parentheses. PR-URL: #35656 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

test: refactor test-crypto-pbkdf2
d54edec
PR-URL: #35693 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Oct 21, 2020

BethGriggs force-pushed the v15.0.1-proposal branch from b94e07b to f7abd6aCompare October 21, 2020 11:22

BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

targos approved these changes Oct 21, 2020
View reviewed changes

Trott approved these changes Oct 21, 2020
View reviewed changes

gengjiawen approved these changes Oct 21, 2020
View reviewed changes

gireeshpunathil approved these changes Oct 21, 2020
View reviewed changes

BethGriggs mentioned this pull request Oct 21, 2020
deps: V8: set correct V8 version patch number #35732
Closed

Trottand others added 4 commits October 21, 2020 15:51

doc: use kbd element in readline doc
b78294d
PR-URL: #35698 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

build: use make functions instead of echo
c509485
PR-URL: #35707 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs force-pushed the v15.0.1-proposal branch from f7abd6a to a84aedcCompare October 21, 2020 14:55

deps: upgrade npm to 7.0.3
595c8df
PR-URL: #35724 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs force-pushed the v15.0.1-proposal branch from a84aedc to 0c5dbc1Compare October 21, 2020 16:04

BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

richardlau requested changes Oct 21, 2020
View reviewed changes

BethGriggs force-pushed the v15.0.1-proposal branch from 0c5dbc1 to 8451c4aCompare October 21, 2020 18:09

BethGriggs requested a review from richardlau October 21, 2020 18:45

richardlau approved these changes Oct 21, 2020
View reviewed changes

BethGriggs added a commit that referenced this pull request Oct 21, 2020
Working on v15.0.2
eff4498
PR-URL: #35736

BethGriggs merged commit 8451c4a into v15.xOct 21, 2020

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Oct 21, 2020
Blog: v15.0.1 release post
e9e505b
PR-URL: nodejs/node#35736

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Oct 21, 2020
Blog: v15.0.1 release post
a34d858
PR-URL: nodejs/node#35736

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Oct 21, 2020
Blog: v15.0.1 release post
6a7ecd9
Refs: nodejs/node#35736

BethGriggs mentioned this pull request Oct 21, 2020
Blog: v15.0.1 release post nodejs/nodejs.org#3466
Merged

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2020
Blog: v15.0.1 release post (#3466)
4d19270
Refs: nodejs/node#35736

BethGriggs deleted the v15.0.1-proposal branch October 22, 2020 20:45

Navigation Menu

Uh oh!

Uh oh!

v15.0.1 proposal - #35736

v15.0.1 proposal#35736
BethGriggs merged 11 commits into
v15.xfrom
v15.0.1-proposal

BethGriggs commented Oct 21, 2020•
edited
Loading

Uh oh!

nodejs-github-bot commented Oct 21, 2020

Uh oh!

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading

Uh oh!

bricss commented Oct 21, 2020

Uh oh!

codecov-io commented Oct 21, 2020•
edited
Loading

Uh oh!

MylesBorins commented Oct 21, 2020

Uh oh!

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading

Uh oh!

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading

Uh oh!

richardlau left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Uh oh!

Conversation

BethGriggs commented Oct 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2020-10-21, Version 15.0.1 (Current), @BethGriggs

Notable changes

Commits

Uh oh!

nodejs-github-bot commented Oct 21, 2020

Uh oh!

nodejs-github-bot commented Oct 21, 2020• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bricss commented Oct 21, 2020

Uh oh!

codecov-io commented Oct 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MylesBorins commented Oct 21, 2020

Uh oh!

nodejs-github-bot commented Oct 21, 2020• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 21, 2020• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

BethGriggs commented Oct 21, 2020•
edited
Loading

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading

codecov-io commented Oct 21, 2020•
edited
Loading

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading

nodejs-github-bot commented Oct 21, 2020•
edited by BethGriggs
Loading