Skip to content

stream: pipeline accept iterable as a valid first argument - #36479

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-stream-pipeline-args
Closed

stream: pipeline accept iterable as a valid first argument#36479
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-stream-pipeline-args

Conversation

@Lxxyx

Copy link
Copy Markdown
Member

Fixes: #36437

Checklist

@LxxyxLxxyx changed the title pipeline: accept iterable as a valid first argumentstream: pipeline accept iterable as a valid first argumentDec 11, 2020
@Lxxyx
Lxxyxforce-pushed the fix-stream-pipeline-args branch from 90f1932 to 029bb0aCompareDecember 11, 2020 14:22
@Lxxyx
Lxxyxforce-pushed the fix-stream-pipeline-args branch from 029bb0a to 86d8a8fCompareDecember 11, 2020 14:23
@ZYSzysZYSzys added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 13, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 45dbcbe...6837a6d

nodejs-github-bot pushed a commit that referenced this pull request Dec 15, 2020
Fixes: #36437
PR-URL: #36479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Lxxyx
Lxxyx deleted the fix-stream-pipeline-args branch December 15, 2020 13:56
targos pushed a commit that referenced this pull request Dec 21, 2020
Fixes: #36437
PR-URL: #36479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
BethGriggs pushed a commit that referenced this pull request Jan 19, 2021
Fixes: #36437
PR-URL: #36479
Backport-PR-URL: #36831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Jan 26, 2021
BethGriggs pushed a commit that referenced this pull request Jan 28, 2021
Fixes: #36437
PR-URL: #36479
Backport-PR-URL: #36831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: stream.pipeline documentation is misleading WRT 'Iterable' as a valid first argument.

8 participants

@Lxxyx@nodejs-github-bot@jasnell@Trott@BridgeAR@aduh95@ZYSzys@targos