v14.15.5 proposal by BethGriggs · Pull Request #37074 · nodejs/node

BethGriggs · 2021-01-26T11:56:34Z

2021-02-09, Version 14.15.5 'Fermium' (LTS), @BethGriggs

Notable Changes

deps:
- upgrade npm to 6.14.11 (Ruy Adorno) #37173
- V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
  - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618

Commits

[20b1e6c802] - deps: V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
[408c7a65f3] - deps: upgrade npm to 6.14.11 (Ruy Adorno) #37173
[017eed665b] - http: do not loop over prototype in Agent (Michaël Zasso) #36410
[25a3204fe2] - http: don't cork .end when not needed (Dimitris Halatsis) #36633
[2a1e4e9244] - stream: accept iterable as a valid first argument (ZiJian Liu) #36479
[9ff73fcdbe] - stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618
[c03cddb46f] - test: http complete response after socket double end (Dimitris Halatsis) #36633
[f206505e9d] - util: fix instanceof checks with null prototypes during inspection (Ruben Bridgewater) #36178
[2f7944b18b] - util: fix module prefixes during inspection (Ruben Bridgewater) #36178

Notable changes: - **deps**: upgrade npm to 6.14.11 (Darcy Clarke) [#36838](#36838) - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) [#36618](#36618) PR-URL: #37074

nodejs-github-bot · 2021-01-26T11:58:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35743/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3706/ ✅
CITGM(v14.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1017/
CITGM(v14.15.5): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2598/

nodejs-github-bot · 2021-01-26T13:24:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35748/ ✅

BethGriggs · 2021-01-26T23:15:12Z

cc: @nodejs/streams as there are a number of streams bug fixes going out in this release.

BethGriggs · 2021-01-26T23:59:55Z

Delayed by a couple of CITGM reruns. Will update the changelog dates to tomorrow and aim to promote in the morning.

Notable changes: - **deps**: upgrade npm to 6.14.11 (Darcy Clarke) [#36838](#36838) - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) [#36618](#36618) PR-URL: #37074

mcollina

lgtm

let me know if there is anything in those CITGM I need to take a look for streams.

BethGriggs · 2021-01-27T21:54:53Z

CITGM is very flaky on both v14.x and v14.15.5 (after several reruns).

┌────────────────────────┬─────────────────────────┬─────────────────┬────────────────────┐
│ (index) │ 0 │ 1 │ 2 │
├────────────────────────┼─────────────────────────┼─────────────────┼────────────────────┤
│ centos7-ppcle │ 'ember-cli-v3.24.0' │ 'semver-v7.3.4' │ 'socket.io-v3.1.0' │
│ osx1015 │ 'fastify-v3.11.0' │ │ │
│ ubuntu1804-64 │ │ │ │
│ fedora-last-latest-x64 │ 'torrent-stream-v1.2.1' │ │ │
│ rhel7-s390x │ 'torrent-stream-v1.2.1' │ │ │
│ ubuntu1604-64 │ 'winston-v3.3.3' │ │ │
│ win-vs2017 │ 'rewire-v5.0.0' │ │ │
│ fedora-latest-x64 │ │ │ │
│ osx1014 │ │ │ │
└────────────────────────┴─────────────────────────┴─────────────────┴────────────────────┘

Summary:

centos7-ppcle failures are known.
osx1015 | fastify is a timeout, which I think we've seen before. The osx machines timeout a lot in CITGM too. Passed locally.
torrent-stream is another familiar flake.
ubuntu1604-64 | winston flake disappeared on rerun.
win-vs2017 | rewire - this one seems new but it's not obvious to me whether it's related:

 1) rewire
should work like require():
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\ADMINI~1\AppData\Local\Temp\448829c9-552d-4523-93e0-c42708400ee7\rewire\test\rewire.test.js)
at processImmediate (internal/timers.js:461:21)

Edit: rewire seems okay on no-build reruns on the rc.0 - https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=win10-vs2019/1021/console

BethGriggs · 2021-01-27T22:47:42Z

Just doing my final testing before release, and I have just noticed npm is reporting 6.14.10 rather than 6.14.11. I think the deps/npm/package.json bump may have been missed in #36838.

@nodejs/npm / @MylesBorins thoughts on how to proceed? Reland #36838 with the version updated to 6.14.11?

I think v10.23.2 might have gone out yesterday with the content of npm 6.14.11 but reports npm 6.14.10.

MylesBorins · 2021-01-27T22:53:11Z

@BethGriggs it looks like there may have been something that went awry with the upgrade commit.

npm/cli@ef5b0d3

The release commit definitely bumped the version number, and the published version of the package has the right version. We could delay and get a fixed version of the update commit for you. what do you think?

BethGriggs · 2021-01-27T22:57:41Z

We could delay and get a fixed version of the update commit for you. what do you think?

@MylesBorins, sure, happy to delay this one to patch up the commit. (Also to be updated on v12.x-staging)

I'm not sure on the best approach for v10.23.2 though

MylesBorins · 2021-01-28T01:05:59Z

@BethGriggs I think we need to see how big the diff is when we get an updated patch.

Fixes: #36437 PR-URL: #36479 Backport-PR-URL: #36831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #36633 Backport-PR-URL: #36940Fixes: #36620 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

PR-URL: #36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #37173 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: #37100 PR-URL: #36178Fixes: #35730Fixes: #36151 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - **deps**: upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

nodejs-github-bot · 2021-02-05T16:56:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35969/

Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: v8/v8@dfcf1e8 PR-URL: #37245 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (#37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

nodejs-github-bot · 2021-02-08T13:57:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36008/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3742/ ✅

mcollina

lgtm

Fixes: #36364 PR-URL: #36410 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (#37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

nodejs-github-bot · 2021-02-08T19:55:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36019/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3743/ (2/3 ✅ )
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3744/ (rerun ✅ )
CITGM(v14.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1029/
CITGM(v14.15.5): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2623/

BethGriggs · 2021-02-09T14:24:22Z

CITGM on v14.15.5 looks okay to me.

Pino is failing on all platforms due to a lint failure, which is being addressed as part of pinojs/pino#961 (cc @mcollina)

mcollina · 2021-02-09T14:33:50Z

thanks, sorry about this. I'll fix asap.

BethGriggs · 2021-02-09T14:36:22Z

Release build on 9fff0d3 : https://ci-release.nodejs.org/job/iojs+release/6655

PR-URL: #37074

Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (#37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

Refs: nodejs/node#37074

nodejs-github-bot added meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Jan 26, 2021

BethGriggs force-pushed the v14.15.5-proposal branch from d71b3a9 to 97f1314Compare January 26, 2021 11:57

richardlau approved these changes Jan 26, 2021
View reviewed changes

BethGriggs force-pushed the v14.15.5-proposal branch from 97f1314 to 8045a8bCompare January 27, 2021 01:27

mcollina approved these changes Jan 27, 2021
View reviewed changes

ruyadorno mentioned this pull request Jan 28, 2021
[v14.x] deps: upgrade npm to 6.14.11 #37107
Closed

Lxxyxand others added 4 commits January 28, 2021 17:56

test: http complete response after socket double end
c03cddb
PR-URL: #36633 Backport-PR-URL: #36940Fixes: #36620 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

http: don't cork .end when not needed
25a3204
PR-URL: #36633 Backport-PR-URL: #36940Fixes: #36620 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

BethGriggs mentioned this pull request Jan 29, 2021
[v14.x backport] util: fix module inspection & instanceof check during inspect #37100
Closed

ruyadornoand others added 3 commits February 4, 2021 11:47

deps: upgrade npm to 6.14.11
408c7a6
PR-URL: #37173 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

BethGriggs added a commit that referenced this pull request Feb 5, 2021
2021-02-08, Version 14.15.5 'Fermium' (LTS)
a1b41b3
Notable changes: - **deps**: upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

BethGriggs force-pushed the v14.15.5-proposal branch from 8045a8b to a1b41b3Compare February 5, 2021 16:53

richardlau approved these changes Feb 5, 2021
View reviewed changes

targos mentioned this pull request Feb 6, 2021
deps: V8: backport dfcf1e86fac0 #37245
Closed

BethGriggs force-pushed the v14.15.5-proposal branch from a1b41b3 to 7b6ab5eCompare February 8, 2021 13:56

mcollina approved these changes Feb 8, 2021
View reviewed changes

targosand others added 2 commits February 8, 2021 17:27

http: do not loop over prototype in Agent
017eed6
Fixes: #36364 PR-URL: #36410 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

BethGriggs force-pushed the v14.15.5-proposal branch from 7b6ab5e to 9fff0d3Compare February 8, 2021 19:12

BethGriggs requested a review from richardlau February 9, 2021 14:26

richardlau approved these changes Feb 9, 2021
View reviewed changes

ruyadorno approved these changes Feb 9, 2021
View reviewed changes

BethGriggs added a commit that referenced this pull request Feb 9, 2021
Working on v14.15.6
93f7f9e
PR-URL: #37074

BethGriggs merged commit 9fff0d3 into v14.xFeb 9, 2021

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Feb 9, 2021
Blog: v14.15.5 release post
c25ed71
Refs: nodejs/node#37074

BethGriggs mentioned this pull request Feb 9, 2021
Blog: v14.15.5 release post nodejs/nodejs.org#3672
Merged

BethGriggs deleted the v14.15.5-proposal branch February 9, 2021 16:59

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Feb 9, 2021
Blog: v14.15.5 release post (#3672)
e89195c
Refs: nodejs/node#37074

targos added the release Issues and PRs related to Node.js releases. label Apr 11, 2021

targos removed npm Issues and PRs related to the npm client dependency or the npm registry. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021

Uh oh!

Uh oh!

Conversation

BethGriggs commented Jan 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2021-02-09, Version 14.15.5 'Fermium' (LTS), @BethGriggs

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Jan 26, 2021• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 26, 2021• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented Jan 26, 2021

Uh oh!

BethGriggs commented Jan 26, 2021

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

BethGriggs commented Jan 27, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented Jan 27, 2021

Uh oh!

MylesBorins commented Jan 27, 2021

Uh oh!

BethGriggs commented Jan 27, 2021

Uh oh!

MylesBorins commented Jan 28, 2021

Uh oh!

nodejs-github-bot commented Feb 5, 2021

Uh oh!

nodejs-github-bot commented Feb 8, 2021• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 8, 2021• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented Feb 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina commented Feb 9, 2021

Uh oh!

BethGriggs commented Feb 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

BethGriggs commented Jan 26, 2021•
edited
Loading

nodejs-github-bot commented Jan 26, 2021•
edited by BethGriggs
Loading

nodejs-github-bot commented Jan 26, 2021•
edited by BethGriggs
Loading

BethGriggs commented Jan 27, 2021•
edited
Loading

nodejs-github-bot commented Feb 8, 2021•
edited by BethGriggs
Loading

nodejs-github-bot commented Feb 8, 2021•
edited by BethGriggs
Loading

BethGriggs commented Feb 9, 2021•
edited
Loading