Uh oh!
There was an error while loading. Please reload this page.
lib: restate the code to use primordials - #36561
Closed
PoojaDurgad wants to merge 1 commit into
Closed
Conversation
PoojaDurgad
commented
Dec 18, 2020
ContributorAuthor
aduh95
commented
Dec 18, 2020
Contributor
PoojaDurgad
commented
Dec 18, 2020
ContributorAuthor
@aduh95 - yeah, looks like this file cannot use primordials. but why ? is there any other files which cannot use primordials? |
aduh95
commented
Dec 18, 2020
Contributor
Not sure, but I think this is a one-of. |
Trott
commented
Dec 21, 2020
Member
Feel free to continue discussion or even re-open if you think appropriate, but I'm going to close this since it doesn't seem like it's going to land. |
| filtered = filtered.split('\n'); | ||
| return out.replace(FUNC_RE, (all, prefix, postfix) => { | ||
| filtered = StringPrototypeSplit(filtered, '\n'); | ||
| return StringPrototypeReplace(out, FUNC_RE, (all, prefix, postfix) => { |
Contributor
There was a problem hiding this comment.
Note that calling StringPrototypeReplace on a RegExp is unsafe, as it calls RegExp.prototype[Symbol.replace].
This should instead use:
Suggested change
| returnStringPrototypeReplace(out,FUNC_RE,(all,prefix,postfix)=>{ | |
| returnRegExpPrototypeSymbolReplace(FUNC_RE,out,(all,prefix,postfix)=>{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes