Skip to content

child_process: support AbortSignal in fork - #36603

Closed
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:child-process-fork-abortcontroller
Closed

child_process: support AbortSignal in fork#36603
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:child-process-fork-abortcontroller

Conversation

@benjamingr

@benjamingrbenjamingr commented Dec 22, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Keeping the AbortSignal support in our APIs up - add the same sort of AbortSignal support we have in .spawn and .execFile to .fork.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingrbenjamingr added child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Dec 22, 2020
@benjamingr
benjamingrforce-pushed the child-process-fork-abortcontroller branch from fafb88e to 6a7fa1aCompareDecember 22, 2020 13:30
Trott
Trott reviewed Dec 22, 2020
View reviewed changes
Comment threaddoc/api/child_process.md Outdated

@TrottTrottDec 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*`signal` {AbortSignal} allows closing the subprocess using an AbortSignal.
*`signal` {AbortSignal} Allows closing the subprocess using an AbortSignal.

@TrottTrottDec 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: The options are in alphabetical order up until uid. Move uid, gid, and signal to the locations in the list to make the list fully alphabetical order.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35044/

@benjamingr
benjamingrforce-pushed the child-process-fork-abortcontroller branch from 6a7fa1a to 18ae659CompareDecember 24, 2020 15:13
@benjamingr

benjamingr commented Dec 24, 2020

Copy link
Copy Markdown
MemberAuthor

@Trott PTAL (commit queue needs a "fresh" review)

@jasnell@addaleax would love a review - I'm trying to make child_process AbortSignal consistent among different methods.

@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35066/

@benjamingrbenjamingr added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 24, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2020
@github-actions

github-actionsBot commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

Landed in 33d99b6...73a21e4

nodejs-github-bot pushed a commit that referenced this pull request Dec 24, 2020
@benjamingr@nodejs-github-bot
child_process: support AbortSignal in fork
73a21e4
PR-URL: #36603
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@benjamingr@danielleadams
child_process: support AbortSignal in fork
a8a427f
PR-URL: #36603
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
7994977
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
ce42dea
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
3d4c36b
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-13, Version 15.6.0 (Current)
cf44a24
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2021-01-13, Version 15.6.0 (Current)
1a5dbf3
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
4c6744c
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
1700bbd
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) (#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
* implement basic secure heap support (James M Snell) (#36779)
* fixup bug in keygen error handling (James M Snell) (#36779)
* introduce X509Certificate API (James M Snell) (#36804)
* implement randomuuid (James M Snell) (#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) (#36793)
* add dnlup to collaborators (Daniele Belardi) (#36849)
* add panva to collaborators (Filip Skokan) (#36802)
* add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
* fix native constructors (ExE Boss) (#36549)
danielleadams added a commit that referenced this pull request Jan 15, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
0f78948
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) (#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
* implement basic secure heap support (James M Snell) (#36779)
* fixup bug in keygen error handling (James M Snell) (#36779)
* introduce X509Certificate API (James M Snell) (#36804)
* implement randomuuid (James M Snell) (#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) (#36793)
* add dnlup to collaborators (Daniele Belardi) (#36849)
* add panva to collaborators (Filip Skokan) (#36802)
* add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
* fix native constructors (ExE Boss) (#36549)
@RaisinTenRaisinTen mentioned this pull request Feb 27, 2021
Closed
@targostargos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr@targos
child_process: support AbortSignal in fork
b9732d4
PR-URL: nodejs#36603
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr@targos
child_process: support AbortSignal in fork
385e8e8
PR-URL: #36603
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjamingr@nodejs-github-bot@jasnell@Trott@addaleax@lpinca@targos