Skip to content

doc: add yashLadha to collaborator - #36666

Closed
yashLadha wants to merge 1 commit into
nodejs:masterfrom
yashLadha:add_collab
Closed

doc: add yashLadha to collaborator#36666
yashLadha wants to merge 1 commit into
nodejs:masterfrom
yashLadha:add_collab

Conversation

@yashLadha

@yashLadhayashLadha commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Fixes: #36500

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 28, 2020
@yashLadhayashLadha added fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. labels Dec 28, 2020
@yashLadha

yashLadha commented Dec 28, 2020

Copy link
Copy Markdown
ContributorAuthor

fast-track?

@yashLadhayashLadha removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 28, 2020
@yashLadhayashLadha added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 28, 2020
@gireeshpunathil

gireeshpunathil commented Dec 28, 2020

Copy link
Copy Markdown
Member

@Trott - usually we land these PRs in the on-boarding session itself with the test completions, but looks like the tests are taking longer. Should we wait, or land?

yashLadha added a commit that referenced this pull request Dec 29, 2020
@yashLadha
doc: add yashLadha to collaborator
5887ba7
Fixes: #36500
PR-URL: #36666
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@yashLadha

yashLadha commented Dec 29, 2020

Copy link
Copy Markdown
ContributorAuthor

Landed in 5887ba7 🎉

@Trott

Trott commented Dec 29, 2020

Copy link
Copy Markdown
Member

@Trott - usually we land these PRs in the on-boarding session itself with the test completions, but looks like the tests are taking longer. Should we wait, or land?

I missed this at the time. Sorry about that. For the future: I usually don't wait for the tests to finish other than the linter jobs.

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@yashLadha@danielleadams
doc: add yashLadha to collaborator
72b0ab0
Fixes: #36500
PR-URL: #36666
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
7994977
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
ce42dea
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
3d4c36b
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-13, Version 15.6.0 (Current)
cf44a24
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2021-01-13, Version 15.6.0 (Current)
1a5dbf3
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
4c6744c
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
* implement basic secure heap support (James M Snell) [#36779](#36779)
* fixup bug in keygen error handling (James M Snell) [#36779](#36779)
* introduce X509Certificate API (James M Snell) [#36804](#36804)
* implement randomuuid (James M Snell) [#36729](#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
* add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
* add panva to collaborators (Filip Skokan) [#36802](#36802)
* add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
* fix native constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
1700bbd
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) (#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
* implement basic secure heap support (James M Snell) (#36779)
* fixup bug in keygen error handling (James M Snell) (#36779)
* introduce X509Certificate API (James M Snell) (#36804)
* implement randomuuid (James M Snell) (#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) (#36793)
* add dnlup to collaborators (Daniele Belardi) (#36849)
* add panva to collaborators (Filip Skokan) (#36802)
* add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
* fix native constructors (ExE Boss) (#36549)
danielleadams added a commit that referenced this pull request Jan 15, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
0f78948
PR-URL: #36889
Notable changes:
* child_process:
* add 'overlapped' stdio flag (Thiago Padilha) (#29412)
* support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
* implement basic secure heap support (James M Snell) (#36779)
* fixup bug in keygen error handling (James M Snell) (#36779)
* introduce X509Certificate API (James M Snell) (#36804)
* implement randomuuid (James M Snell) (#36729)
* doc:
* update release key for Danielle Adams (Danielle Adams) (#36793)
* add dnlup to collaborators (Daniele Belardi) (#36849)
* add panva to collaborators (Filip Skokan) (#36802)
* add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
* set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
* support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
* add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
* fix native constructors (ExE Boss) (#36549)
targos pushed a commit that referenced this pull request May 1, 2021
@yashLadha@targos
doc: add yashLadha to collaborator
535bbc2
Fixes: #36500
PR-URL: #36666
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@PoojaDurgadPoojaDurgadPoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating @YashLadha as a collaborator

6 participants

@yashLadha@gireeshpunathil@Trott@aduh95@PoojaDurgad@nodejs-github-bot