deps: V8: backport dfcf1e86fac0 by targos · Pull Request #37245 · nodejs/node

targos · 2021-02-06T10:18:31Z

Original commit message:

[wasm] PostMessage of Memory.buffer should throw
PostMessage of an ArrayBuffer that is not detachable should result
in a DataCloneError.
Bug: chromium:1170176, chromium:961059
Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: v8/v8@dfcf1e8

targos · 2021-02-06T10:18:56Z

Fast-track to include in #37074.

nodejs-github-bot · 2021-02-06T10:21:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35973/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3733/
Rebuild: https://ci.nodejs.org/job/node-test-commit-v8-linux/3735/ ✅

aduh95

RSLGTM

mcollina

lgtm, and +1 to fast-track

nodejs-github-bot · 2021-02-06T16:37:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35980/

Trott · 2021-02-06T16:39:32Z

Is the heap test failure in the initial V8 CI anything to worry about?

targos · 2021-02-07T08:30:20Z

Is the heap test failure in the initial V8 CI anything to worry about?

It's certainly not related to this change. I say we worry about it only if it happens again, maybe the machine was high on memory.

targos · 2021-02-07T09:25:08Z

Landed in aac2713

Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: v8/v8@dfcf1e8 PR-URL: #37245 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (#37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: v8/v8@dfcf1e8 PR-URL: #37245 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * deps: * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245) * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

Notable changes: * deps: * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173) * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245) * Note: Node.js is not believed to be vulnerable to CVE-2021-21148. PR-URL: #37286

Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (#37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (#37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (#36618) PR-URL: #37074

ruyadorno · 2021-02-10T03:28:47Z

This did not landed cleanly in v12.x and I believe it might need to be properly backported.

I tried to land it directly and manually fixed conflicts (result being 680496e) but that ended up breaking all V8 ci tests. I believe a more informed backport is required here 😊

targos · 2021-02-12T16:41:13Z

If this patch doesn't work for v12.x, I don't know who has the knowledge and time to work on a correct one :(

Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: v8/v8@dfcf1e8 PR-URL: #37245 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added v8 engine Issues and PRs related to the V8 dependency. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 6, 2021

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 6, 2021

danbev approved these changes Feb 6, 2021
View reviewed changes

aduh95 approved these changes Feb 6, 2021
View reviewed changes

Trott approved these changes Feb 6, 2021
View reviewed changes

mcollina approved these changes Feb 6, 2021
View reviewed changes

vdeturckheim approved these changes Feb 6, 2021
View reviewed changes

cjihrig approved these changes Feb 6, 2021
View reviewed changes

targos closed this Feb 7, 2021

targos deleted the v8-fix branch February 7, 2021 09:25

BethGriggs mentioned this pull request Feb 8, 2021
v14.15.5 proposal #37074
Merged

ruyadorno added a commit that referenced this pull request Feb 9, 2021
2021-02-09, Version 12.20.2 (LTS)
e28966f
Notable changes: * deps: * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245) * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

ruyadorno added a commit that referenced this pull request Feb 9, 2021
2021-02-09, Version 12.20.2 'Erbium' (LTS)
209e1ba
Notable changes: * deps: * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245) * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

ruyadorno mentioned this pull request Feb 9, 2021
v12.20.2 proposal #37286
Merged

ruyadorno added the backport-requested-v12.x label Feb 10, 2021

This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged

Navigation Menu

Uh oh!

Uh oh!

deps: V8: backport dfcf1e86fac0 - #37245

deps: V8: backport dfcf1e86fac0#37245
targos wants to merge 1 commit into
nodejs:masterfrom
targos:v8-fix

targos commented Feb 6, 2021

Uh oh!

targos commented Feb 6, 2021

Uh oh!

nodejs-github-bot commented Feb 6, 2021•
edited by Trott
Loading

Uh oh!

aduh95 left a comment

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Feb 6, 2021

Uh oh!

Trott commented Feb 6, 2021

Uh oh!

targos commented Feb 7, 2021

Uh oh!

targos commented Feb 7, 2021

Uh oh!

ruyadorno commented Feb 10, 2021•
edited
Loading

Uh oh!

targos commented Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

targos commented Feb 6, 2021

Uh oh!

targos commented Feb 6, 2021

Uh oh!

nodejs-github-bot commented Feb 6, 2021• edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 6, 2021

Uh oh!

Trott commented Feb 6, 2021

Uh oh!

targos commented Feb 7, 2021

Uh oh!

targos commented Feb 7, 2021

Uh oh!

ruyadorno commented Feb 10, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Feb 6, 2021•
edited by Trott
Loading

ruyadorno commented Feb 10, 2021•
edited
Loading