Skip to content

deps: update to cjs-module-lexer@1.1.1 - #37992

Closed
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:cjs-module-lexer-update
Closed

deps: update to cjs-module-lexer@1.1.1#37992
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:cjs-module-lexer-update

Conversation

@guybedford

@guybedfordguybedford commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

This updates to cjs-module-lexer@1.1.1, with the following patches:

Both are for Babel reexports patterns, backports will be necessary for compat.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 30, 2021
@guybedford

guybedford commented Mar 30, 2021

Copy link
Copy Markdown
ContributorAuthor

@nodejs/modules

@guybedford
guybedfordforce-pushed the cjs-module-lexer-update branch from 320e58f to 8706fb8CompareMarch 30, 2021 18:51
@guybedford
guybedfordforce-pushed the cjs-module-lexer-update branch from 8706fb8 to c97633bCompareMarch 30, 2021 18:56
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37066/

@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37070/

aduh95
aduh95 approved these changes Mar 31, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This was referenced Mar 31, 2021
Closed
Closed
guybedford added a commit that referenced this pull request Apr 1, 2021
@guybedford
deps: update to cjs-module-lexer@1.1.1
0d66317
PR-URL: #37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@guybedford

guybedford commented Apr 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 0d66317.

MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@guybedford@MylesBorins
deps: update to cjs-module-lexer@1.1.1
4ef102d
PR-URL: #37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 4, 2021
Merged
guybedford added a commit that referenced this pull request Apr 14, 2021
@guybedford
deps: update to cjs-module-lexer@1.1.1
d56079a
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@guybedford@richardlau
deps: update to cjs-module-lexer@1.1.1
7d5a2f9
PR-URL: #37992
Backport-PR-URL: #38003
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 23, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawengengjiawengengjiawen approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guybedford@nodejs-github-bot@gengjiawen@aduh95@targos