Skip to content

v12.22.4 proposal - #39500

Merged
richardlau merged 23 commits into
v12.xfrom
v12.22.4-proposal
Jul 29, 2021
Merged

v12.22.4 proposal#39500
richardlau merged 23 commits into
v12.xfrom
v12.22.4-proposal

Conversation

@richardlau

@richardlaurichardlau commented Jul 23, 2021•
edited
Loading

Copy link
Copy Markdown
Member

2021-07-29, Version 12.22.4 'Erbium' (LTS), @richardlau

This is a security release.

Notable Changes

Commits

phillipjand others added 14 commits July 23, 2021 11:41
@phillipj@richardlau
build: label PRs with GitHub Action instead of nodejs-github-bot
98ac3c4
Main goal of using a GitHub Action for labelling PRs has been to move
the mapping between files changed -> label into a configuration file
local to the nodejs/node repository.
Previously any changes to that mapping meant having to grasp the
nodejs/github-bot project, open a PR with the neccessary changes, get
approval from its maintainers before those changes finally got pushed
to production.
The logic involved in using the file paths / label configuration and
resolving the labels to be applied, has been moved into a custom GitHub
Action project: nodejs/node-pr-labeler.
Aside from removing the external dependency the nodejs-github-bot is in
practise, it also reduces the bar for contributors since the resulting
project is a lot smaller and less complex than nodejs/github-bot.
PR-URL: #38301Fixes: nodejs/github-bot#294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos@richardlau
build: fix label-pr workflow
499e56b
PR-URL: #38399
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Milad Fa@richardlau
deps: V8: cherry-pick 530080c44af2
93a1a3c
Original commit message:
```
PPC: Add Power10 to the supported list and enable related features
This CL adds Power10 recognition to Linux, AIX as well as IBMi.
Enabled features include:
MODULO
FPR_GPR_MOV
SIMD
LWSYNC
ISELECT
VSX
Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Junliang Yan <junyan@redhat.com>
Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#74279}
```
Refs: v8/v8@530080c
PR-URL: #38509
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos@richardlau
deps: V8: backport 1b1eda0876aa
bbceab4
Original commit message:
tracing: Update proto library build rule and roll Perfetto
This patch removes use of the deprecated sources_assignment_filter GN
feature from gni/proto_library.gni, since the extra descriptor files are
no longer being generated.
We also roll Perfetto to match the version used in Chrome and update
test expectations accordingly.
Bug: v8:10995
Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70381}
Refs: v8/v8@1b1eda0
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick 92e6d3317082
2b54156
Original commit message:
build: Remove no-op calls to set_sources_assignment_filter
Chromiun no longer use set_sources_assignment_filter() anywhere in the
build, so these are no longer needed.
Bug: chromium:1018739
Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70405}
Refs: v8/v8@92e6d33
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick e6f62a41f5ee
492b0d6
Original commit message:
[build] Remove jumbo build configs
Bug: chromium:994387
Change-Id: I7b37a416ce6cc79903fe04923e86af1d0065ac37
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890090
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64669}
Refs: v8/v8@e6f62a4
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick 7b3332844212
a73275f
Original commit message:
[build] Move split_static_library.gni from Chromium repo
We'll remove the file from Chromium in a follow up after V8 has rolled
+ 2 days.
Bug: v8:9911
Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64742}
Refs: v8/v8@7b33328
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick cc641f6be756
add7b5b
Original commit message:
Add a simple gclient_args.gni file to V8
Bug: v8:9914
Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64680}
Refs: v8/v8@cc641f6
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick 7c182bd65f42
f4377b1
Original commit message:
Fix visiblity rules for configs enforced by the latest GN version.
Prior versions of GN had a bug (gn:22) where visibility rules
for configs weren't being enforced properly.
This CL tweaks the visibility settings of some configs to
conform to the latest version.
Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69463}
Refs: v8/v8@7c182bd
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: cherry-pick 0b3a4ecf7083
8046daf
Original commit message:
Fix implicit conversion loses integer precision warning
The type of m is long in 64 bits build, and results implicit conversion
loses integer precision, which was found by improved clang warning
(-Wshorten-64-to-32)
Bug: chromium:1124085
Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
Commit-Queue: Zequan Wu <zequanwu@google.com>
Auto-Submit: Zequan Wu <zequanwu@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69686}
Refs: v8/v8@0b3a4ec
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: backport 895949419186
15b91fa
Original commit message:
Add -Wno-string-concatenation to test/cctest:cctest_sources
v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.
Bug: chromium:1114873
Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69625}
Refs: v8/v8@8959494
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos@richardlau
deps: V8: update build dependencies
906b43e
These updates are necessary to build V8 with recent GN versions.
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@guybedford@richardlau
deps: update to cjs-module-lexer@1.1.1
7d5a2f9
PR-URL: #37992
Backport-PR-URL: #38003
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@guybedford@richardlau
deps: update to cjs-module-lexer@1.2.1
b3c698a
PR-URL: #38450
Backport-PR-URL: #39422
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39242/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4173/

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39245/
Release candidate build with 9ac9229: https://ci-release.nodejs.org/job/iojs+release/7049/
Release candidate download: https://nodejs.org/download/rc/v12.22.4-rc.0/

@richardlaurichardlau mentioned this pull request Jul 26, 2021
Closed
addaleaxand others added 4 commits July 26, 2021 16:30
@addaleax@richardlau
src: update cares_wrap OpenBSD defines
30ce0e6
Move the `#define`s back into `cares_wrap.cc`, as they are part of
the implementation, not the declarations used in `cares_wrap.h`,
and apply the suggestion from
#38572 (comment)
to make the defines a bit more generic and not check for OpenBSD
specifically.
Refs: #38572
PR-URL: #38670
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@indutny@richardlau
src: move CHECK in AddIsolateFinishedCallback
f552c45
`CHECK(it->second)` asserts that we have `PerIsolatePlatformData`
in the `per_isolate_` map, and not just a key with empty value. When
`it == per_isolate_.end()`, however, it means that we don't have the
isolate and the `CHECK(it->second)` is guaranteed to fail then!
PR-URL: #38010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos@richardlau
deps: V8: cherry-pick 035c305ce776
e459c79
Original commit message:
[Intl] call new ListFormatter::createInstance
The one we currently using is now marked as internal and to be removed
for 68. Migrating to the style which already avaiable in ICU 67-1.
Bug: v8:11031
Change-Id: I668382a2e1b8602ddca02bf231c5008a6c92bf2d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477751
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70638}
Refs: v8/v8@035c305
PR-URL: #38497
Backport-PR-URL: #39451
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau
deps: restore minimum ICU version to 65
39e9cd5
This modifies 40df0dc so that the changes it applies are only used
if ICU 67 or greater is used, and restores the previous code path for
versions of ICU below 67.
The minimum ICU version was bumped to 67 in Node.js 14.6.0 by
#34356 but the referenced V8
commit[1] isn't on `v14.x-staging` and appears to have been reverted
on V8 8.4[2] so this PR also restores the minimum ICU version to 65.
[1] v8/v8@611e412
[2] v8/v8@eeccede
PR-URL: #39068
Backport-PR-URL: #39451
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
targos
targos reviewed Jul 26, 2021
View reviewed changes
Comment threaddoc/changelogs/CHANGELOG_V12.md Outdated
Comment on lines 80 to 86

@targostargosJul 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be removed if there's nothing of note

@richardlaurichardlauJul 26, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing of note... yet. I've been asked to add a few more commits to this, which will be notable, but they're not ready yet.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@lxdicted@richardlau
deps: update to c-ares 1.17.1
e11a862
PR-URL: #36207
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39281/

@kumarak@richardlau
http2: on receiving rst_stream with cancel code add it to pending list
b263f25
PR-URL: #39423
Backport-PR-URL: #39527Fixes: #38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39300/

darcyclarkeand others added 2 commits July 28, 2021 19:37
@darcyclarke@richardlau
deps: upgrade npm to 6.14.14
ddc8dde
PR-URL: #39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@aduh95@richardlau
module: fix legacy node specifier resolution to resolve "main" field
3e4bc1b
PR-URL: #38979
Backport-PR-URL: #39497Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau added a commit that referenced this pull request Jul 28, 2021
@richardlau
2021-07-29, Version 12.22.4 'Erbium' (LTS)
bbec863
Notable changes:
- CVE-2021-22930: Use after free on close http2 on stream canceling (High)
PR-URL: #39500
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39322/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4179/ ✅
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2730/

@richardlau
2021-07-29, Version 12.22.4 'Erbium' (LTS)
2fdf989
This is a security release.
Notable changes:
- CVE-2021-22930: Use after free on close http2 on stream canceling (High)
PR-URL: #39500
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39335/ ✅
Release build with 2fdf989: https://ci-release.nodejs.org/job/iojs+release/7057/

@richardlau
richardlau merged commit 2fdf989 into v12.xJul 29, 2021
richardlau added a commit that referenced this pull request Jul 29, 2021
@richardlau
Working on v12.22.5
f2f7a45
PR-URL: #39500
richardlau added a commit that referenced this pull request Jul 29, 2021
@richardlau
2021-07-29, Version 12.22.4 'Erbium' (LTS)
9b41994
This is a security release.
Notable changes:
- CVE-2021-22930: Use after free on close http2 on stream canceling (High)
PR-URL: #39500
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Jul 29, 2021
@richardlau
Blog: v12.22.4 release post
9b5d915
Refs: nodejs/node#39500
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Jul 29, 2021
@richardlau
Blog: v12.22.4 release post
a5c9990
Refs: nodejs/node#39500
@richardlaurichardlau mentioned this pull request Jul 29, 2021
Merged
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Jul 29, 2021
@richardlau
Blog: v12.22.4 release post (#4008)
89ce3fe
Refs: nodejs/node#39500
@richardlau
richardlau deleted the v12.22.4-proposal branch July 29, 2021 17:05
@targostargos added release Issues and PRs related to Node.js releases. v12.x labels Sep 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments

Assignees

No one assigned

Labels

releaseIssues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@richardlau@nodejs-github-bot@targos@phillipj@guybedford@addaleax@indutny@lxdicted@kumarak@darcyclarke@aduh95