Skip to content

fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown - #37997

Closed
ycjcl868 wants to merge 3 commits into
nodejs:masterfrom
ycjcl868:fs-chown-range
Closed

fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown#37997
ycjcl868 wants to merge 3 commits into
nodejs:masterfrom
ycjcl868:fs-chown-range

Conversation

@ycjcl868

@ycjcl868ycjcl868 commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Fixes: #37995

Uint32 should be between [0, 2 ** 32)

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Mar 31, 2021
@RaisinTen

RaisinTen commented Mar 31, 2021

Copy link
Copy Markdown
Member

I'm not sure that this is a valid fix for this issue as -1 is actually an accepted value for owner and group. This is almost like a revert of #31694 which added support for -1.

@benjamingrbenjamingr mentioned this pull request Mar 31, 2021
@ycjcl868ycjcl868 changed the title fix: valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchownfs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchownApr 1, 2021
@ycjcl868

Copy link
Copy Markdown
ContributorAuthor

Fix by #38004, Closed

@ycjcl868ycjcl868 closed this Apr 1, 2021
@ycjcl868
ycjcl868 deleted the fs-chown-range branch April 1, 2021 01:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"fs.chownSync" results in an abort

3 participants

@ycjcl868@RaisinTen@nodejs-github-bot