Uh oh!
There was an error while loading. Please reload this page.
fs: fix chown abort - #38004
Closed
RaisinTen wants to merge 5 commits into
Closed
Conversation
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: nodejs#37995 Refs: nodejs#31694
aduh95
reviewed
Mar 31, 2021
| const kWriteFileMaxChunkSize = 512 * 1024; | ||
| // 2 ** 32 - 1 | ||
| const kMaxUserId = 4294967295; |
Contributor
There was a problem hiding this comment.
Why this value? Is this documented somewhere? Could you add a comment explaining where does it come from please?
MemberAuthor
There was a problem hiding this comment.
I actually pasted it from:
Lines 139 to 140 in 82bc5c3
since I could not require it because of a circular dependency.
Should we move this (and possibly other k* constants) into
lib/internal/fs/utils.js and require them from there?addaleax
approved these changes
Mar 31, 2021
benjamingr
commented
Mar 31, 2021
Member
Nice, though looks like #37997 was opened already? |
ycjcl868
commented
Apr 1, 2021
Contributor
CI broken |
RaisinTen
commented
Apr 1, 2021
MemberAuthor
@benjamingr I opened this as it has a different approach of fixing the issue. Also, #37997 (comment). |
nodejs-github-bot
commented
Apr 1, 2021
Collaborator
RaisinTen
commented
Apr 1, 2021
MemberAuthor
@ycjcl868 The Github Actions CI seems to be fixed now. Started the Jenkins CI run. |
Trott
approved these changes
Apr 3, 2021
Trott
commented
Apr 3, 2021
Member
Landed in e9ed113 |
Trott pushed a commit
that referenced
this pull request
Apr 3, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
RaisinTen added a commit
to RaisinTen/node
that referenced
this pull request
Apr 3, 2021
MylesBorins pushed a commit
that referenced
this pull request
Apr 4, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Apr 5, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Apr 6, 2021
Refs: #38004 (comment) PR-URL: #38061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MoritzLoewenstein pushed a commit
to MoritzLoewenstein/node
that referenced
this pull request
Sep 1, 2021
Refs: nodejs#38004 (comment) PR-URL: nodejs#38061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: #38004 (comment) PR-URL: #38061 Backport-PR-URL: #39838 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This syncs the type assertion introduced in the referenced PR in the C++
side. Since chown, lchown, and fchown can accept -1 as a value for uid
and gid, we should also accept signed integers from the JS side.
Fixes: #37995
Refs: #31694