Skip to content

module: fix legacy node specifier resolution to resolve "main" field - #38979

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:resolve-main-node
Jun 13, 2021
Merged

module: fix legacy node specifier resolution to resolve "main" field#38979
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:resolve-main-node

Conversation

@aduh95

@aduh95aduh95 commented Jun 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #38739
Fixes: #32103

@github-actionsgithub-actionsBot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jun 9, 2021
RaisinTen
RaisinTen reviewed Jun 9, 2021
View reviewed changes
Comment threadtest/fixtures/es-module-specifiers/dir-with-main/main.js Outdated
RaisinTen
RaisinTen reviewed Jun 9, 2021
View reviewed changes
Comment threadtest/fixtures/es-module-specifiers/dir-with-main/package.json Outdated
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38549/

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38550/

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38553/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2021
@aduh95

aduh95 commented Jun 11, 2021

Copy link
Copy Markdown
ContributorAuthor

@nodejs/modules FYI

ljharb
ljharb reviewed Jun 11, 2021
View reviewed changes

@ljharbljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zackschuster

zackschuster commented Jun 12, 2021

Copy link
Copy Markdown

what's the rationale for allowing this? iirc exports replaces main entirely, with the intent of deprecating & removing main. cc @ljharb since i saw your dissent in the other issue & your LGTM here.

(+0 on this change, if curious; i do not wish to block anything)

@ljharb

ljharb commented Jun 12, 2021

Copy link
Copy Markdown
Member

“exports” isn’t required; packages aren’t going to be forced to use it and its encapsulation feature. “main” isn’t deprecated.

@aduh95
module: fix legacy node specifier resolution to resolve "main" field
4e17ffc
PR-URL: nodejs#38979Fixes: nodejs#32103Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@aduh95
aduh95force-pushed the resolve-main-node branch from aa99628 to 4e17ffcCompareJune 13, 2021 14:23
@aduh95
aduh95 merged commit 4e17ffc into nodejs:masterJun 13, 2021
@aduh95
aduh95 deleted the resolve-main-node branch June 13, 2021 14:23
@aduh95

aduh95 commented Jun 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 4e17ffc

@aduh95aduh95 mentioned this pull request Jun 13, 2021
Closed
3 tasks
danielleadams pushed a commit that referenced this pull request Jun 14, 2021
@aduh95@danielleadams
module: fix legacy node specifier resolution to resolve "main" field
92ed1c6
PR-URL: #38979Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jun 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@aduh95@danielleadams
module: fix legacy node specifier resolution to resolve "main" field
51be97d
PR-URL: #38979Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@aduh95@richardlau
module: fix legacy node specifier resolution to resolve "main" field
3bc3d11
PR-URL: #38979Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95@richardlau
module: fix legacy node specifier resolution to resolve "main" field
afb6178
PR-URL: #38979Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Merged
@aduh95aduh95 mentioned this pull request Jul 23, 2021
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jul 28, 2021
@aduh95
module: fix legacy node specifier resolution to resolve "main" field
43724ac
PR-URL: nodejs#38979Fixes: nodejs#32103Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@aduh95@richardlau
module: fix legacy node specifier resolution to resolve "main" field
f0bb3d2
PR-URL: #38979
Backport-PR-URL: #39497Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@aduh95@richardlau
module: fix legacy node specifier resolution to resolve "main" field
3e4bc1b
PR-URL: #38979
Backport-PR-URL: #39497Fixes: #32103Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 28, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb left review comments
@RaisinTenRaisinTenRaisinTen left review comments
@guybedfordguybedfordguybedford approved these changes
+1 more reviewer
@bmeckbmeckbmeck approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

7 participants

@aduh95@nodejs-github-bot@zackschuster@ljharb@bmeck@guybedford@RaisinTen