Skip to content

[v12.x] http2: patch double-free error due to handling of rst_stream - #39527

Closed
kumarak wants to merge 1 commit into
nodejs:v12.x-stagingfrom
kumarak:kumarak/v12.x-stagging-build-error
Closed

[v12.x] http2: patch double-free error due to handling of rst_stream#39527
kumarak wants to merge 1 commit into
nodejs:v12.x-stagingfrom
kumarak:kumarak/v12.x-stagging-build-error

Conversation

@kumarak

@kumarakkumarak commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

The PR patches the double-free error due to handling of
RST_STREAM frame with cancel code.

The previous PR(#39423) causes build failure with
v12.x-staging branch since the interfaces to check the
session flags changes. The changes backport APIs to
check the status flag of Http2Session as well.

Ref: #39423
Fixes: #38964

@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39273/

@richardlaurichardlau changed the title http2: patch double-free error due to handling of rst_stream in v12.x-staging[v12.x] http2: patch double-free error due to handling of rst_streamJul 26, 2021
@richardlau

richardlau commented Jul 26, 2021

Copy link
Copy Markdown
Member

cc @nodejs/http2
I'll add a fast track label so we can get this into tomorrow's 12.22.4 release (#39500) if it's acceptable and passes CI.

@richardlaurichardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 26, 2021
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39275/

mcollina
mcollina approved these changes Jul 26, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and +1 to fast track

@richardlau
richardlauforce-pushed the kumarak/v12.x-stagging-build-error branch from f80771d to ba2ac7bCompareJuly 26, 2021 16:40
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39282/

@richardlau

richardlau commented Jul 26, 2021

Copy link
Copy Markdown
Member

Rebased as v12.x-staging was force-pushed.

@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39285/

@github-actionsgithub-actionsBot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v12.x labels Jul 26, 2021
richardlau pushed a commit that referenced this pull request Jul 27, 2021
@kumarak@richardlau
http2: on receiving rst_stream with cancel code add it to pending list
e47d2d2
PR-URL: #39423
Backport-PR-URL: #39527Fixes: #38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 27, 2021
@kumarak@richardlau
http2: on receiving rst_stream with cancel code add it to pending list
b263f25
PR-URL: #39423
Backport-PR-URL: #39527Fixes: #38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@richardlau

richardlau commented Jul 27, 2021

Copy link
Copy Markdown
Member

Landed in e47d2d2.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumarak@nodejs-github-bot@richardlau@mcollina@BethGriggs