Uh oh!
There was an error while loading. Please reload this page.
module: fix ERR_REQUIRE_ESM error for null frames - #39593
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
guybedford
commented
Jul 30, 2021
ContributorAuthor
Requesting a fast track on this fix as well, please upvote this comment. //cc @nodejs/modules |
guybedford referenced
this pull request
Jul 30, 2021
PR-URL: #39175 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
commented
Jul 30, 2021
Collaborator
bmeck
approved these changes
Jul 30, 2021
Trott
approved these changes
Jul 30, 2021
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
commented
Jul 31, 2021
Collaborator
Contributor
Landed in 46e6c64...b0a6ade |
nodejs-github-bot pushed a commit
that referenced
this pull request
Jul 31, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 2, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
silverwind
commented
Aug 2, 2021
Contributor
This broke quite a few things like webpack and eslint, it would be good to have a 16.6.1 release with this fix included. |
targos
commented
Aug 2, 2021
Member
I'm preparing a release for tomorrow. |
targos pushed a commit
that referenced
this pull request
Aug 2, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where ERR_REQUIRE_ESM would throw a
endsWitherror for string when checking null error frames as reported in e2a6399#commitcomment-54198959.