Uh oh!
There was an error while loading. Please reload this page.
[v16.x] deps: revert ABI-breaking change from V8 9.2 - #39624
Closed
targos wants to merge 1 commit into
Closed
Conversation
targos
commented
Aug 2, 2021
MemberAuthor
Contributor
Fast-track has been requested by @targos. Please 👍 to approve. |
targos
commented
Aug 2, 2021
MemberAuthor
I'd like to fast-track this and include it in a small patch release tomorrow. |
targos
commented
Aug 2, 2021
MemberAuthor
Collaborator
addaleax
approved these changes
Aug 2, 2021
aduh95
approved these changes
Aug 2, 2021
gireeshpunathil
approved these changes
Aug 2, 2021
BethGriggs
approved these changes
Aug 2, 2021
richardlau
approved these changes
Aug 2, 2021
Flarna
approved these changes
Aug 2, 2021
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/39415/ |
targos
commented
Aug 2, 2021
MemberAuthor
Landed in 41e105b29438499ec024820b4bbfc6797cbf9311 |
targos added a commit
that referenced
this pull request
Aug 2, 2021
Refs: v8/v8@a7980d4 Refs: v8/v8@ad4eab0Fixes: #39623 PR-URL: #39624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@a7980d4
Refs: v8/v8@ad4eab0
Fixes: #39623