Skip to content

stream: do not emit end on readable error - #39607

Closed
szmarczak wants to merge 1 commit into
nodejs:masterfrom
szmarczak:fix-http2-end
Closed

stream: do not emit end on readable error#39607
szmarczak wants to merge 1 commit into
nodejs:masterfrom
szmarczak:fix-http2-end

Conversation

@szmarczak

@szmarczakszmarczak commented Jul 31, 2021

Copy link
Copy Markdown
Member
  • Include tests for any bug fixes or new features.
  • Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Fixes#39400

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 31, 2021
Mesteery
Mesteery reviewed Jul 31, 2021
View reviewed changes
Comment threadtest/parallel/test-http2-empty-frame-without-eof.js Outdated
@szmarczakszmarczak changed the title fix: do not emit end on http2 stream errorhttp2: do not emit end on stream errorJul 31, 2021
@szmarczak
szmarczakforce-pushed the fix-http2-end branch 2 times, most recently from c35bc4b to 5f8285dCompareJuly 31, 2021 13:08
@szmarczakszmarczak changed the title http2: do not emit end on stream errorstream: do not emit end on readable errorJul 31, 2021
ronag
ronag approved these changes Jul 31, 2021
View reviewed changes

@ronagronag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would prefer an approval from @lpinca on this one.

lpinca
lpinca reviewed Jul 31, 2021
View reviewed changes
Comment threadtest/parallel/test-http2-empty-frame-without-eof.js
Comment threadtest/parallel/test-http2-server-socket-destroy.js
@lpincalpinca added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 31, 2021
@lpinca

lpinca commented Jul 31, 2021

Copy link
Copy Markdown
Member

LGTM if CITGM is "green".

@lpinca

lpinca commented Jul 31, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Marked this semver-major out of caution. If there are no surprises in CITGM I'm also ok with semver-patch as per #39400 (comment).

@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39384/

@szmarczak

szmarczak commented Jul 31, 2021

Copy link
Copy Markdown
MemberAuthor

I noticed aix fails - it does so on other PRs as well.

@targostargos added needs-citgm PRs that need a CITGM CI run. stream Issues and PRs related to the stream subsystem. labels Aug 1, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2021•
edited by targos
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39395/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2737/

@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39413/

@mcollina

mcollina commented Aug 2, 2021

Copy link
Copy Markdown
Member

I think this might be breaking a few ecosystem modules. Specifically:

  • undici
  • pump
  • hapi
  • socket.io

Those needs to be investigated.

Here is a CITGM (master) to see the status there for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2738/

@szmarczak

szmarczak commented Aug 2, 2021

Copy link
Copy Markdown
MemberAuthor

pump is already built into Node.js.

@mcollina

mcollina commented Aug 2, 2021

Copy link
Copy Markdown
Member

pump is already built into Node.js.

It's still a module with a massive amount of downloads that we cannot break.

@targos

targos commented Aug 2, 2021

Copy link
Copy Markdown
Member

The error with pump also happens on the master run.

@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39423/

mcollina
mcollina requested changes Aug 3, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making my objection visible until we have tracked down the CITGM failures.

mcollina
mcollina approved these changes Aug 3, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The test for those modules turned out ok for me. +1

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39459/

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39464/

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39466/

@mcollinamcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2021
@github-actions

github-actionsBot commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Landed in c61870c...ef992f6

nodejs-github-bot pushed a commit that referenced this pull request Aug 5, 2021
@szmarczak@nodejs-github-bot
stream: do not emit end on readable error
ef992f6
PR-URL: #39607
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 15, 2021
Merged
2 tasks
BethGriggs added a commit that referenced this pull request Oct 15, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
75a1290
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- v8: remove --harmony-top-level-await
(Geoffrey Booth) [#40226]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for th `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 15, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
086cd03
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- v8: remove --harmony-top-level-await
(Geoffrey Booth) [#40226]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 16, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
0442e86
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 18, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
cc0bbac
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 18, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
f99ce7c
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 19, 2021
@BethGriggs
2021-10-19, Version 17.0.0 (Current)
d6c3a10
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@ronagronagronag approved these changes
+1 more reviewer
@MesteeryMesteeryMesteery left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.needs-citgmPRs that need a CITGM CI run.semver-majorPRs that contain breaking changes and should be released in the next major version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http2: end is emitted before error when destroying client stream

8 participants

@szmarczak@lpinca@nodejs-github-bot@mcollina@targos@jasnell@ronag@Mesteery