Skip to content

doc: deprecate (doc-only) .aborted property and 'abort', 'aborted' event in http - #36670

Closed
dr-js wants to merge 1 commit into
nodejs:masterfrom
dr-js:deprecate-http-abort-related
Closed

doc: deprecate (doc-only) .aborted property and 'abort', 'aborted' event in http#36670
dr-js wants to merge 1 commit into
nodejs:masterfrom
dr-js:deprecate-http-abort-related

Conversation

@dr-js

Copy link
Copy Markdown
Contributor

Refs: #36641
Refs: #36617 (comment)

Documentation-only deprecate .aborted property and 'abort', 'aborted' event in http, and suggest using the corresponding Stream API instead.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 29, 2020
@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from 0352bb4 to 334787fCompareDecember 29, 2020 02:19
@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from 334787f to 80ee6eeCompareDecember 29, 2020 02:25
Comment threaddoc/api/deprecations.md Outdated
@Trott

Copy link
Copy Markdown
Member

Welcome @dr-js and thanks for the pull request!

@ronagronag added the http Issues or PRs related to the http subsystem. label Dec 30, 2020
@ronag

Copy link
Copy Markdown
Member

@nodejs/http

Comment threaddoc/api/deprecations.md Outdated
@jasnelljasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 9, 2021
Comment threaddoc/api/deprecations.md Outdated
@aduh95

Copy link
Copy Markdown
Contributor

@dr-js Can you please rebase on top of master to solve the git conflict?

@jasnell Could you elaborate on why this is labeled semver-major? IIRC doc deprecation are usually semver-minor.

@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from 768b96f to bc927d6CompareJanuary 19, 2021 00:00
@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from bc927d6 to 2eb751cCompareFebruary 3, 2021 14:01
@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from 2eb751c to 9fec6fdCompareMarch 4, 2021 13:20
@aduh95

Copy link
Copy Markdown
Contributor

@dr-js can you please rebase again?

Ping @nodejs/http for reviews.

@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch 2 times, most recently from bc1f2a9 to 3e204fdCompareSeptember 16, 2021 04:47
Refs: nodejs#36641
Refs: nodejs#36617 (comment)
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@dr-js
dr-jsforce-pushed the deprecate-http-abort-related branch from 3e204fd to d9fb8aeCompareSeptember 16, 2021 05:08
@targostargos added deprecations Issues and PRs related to deprecations. notable-change PRs with changes that should be highlighted in changelogs. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 18, 2021

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina pushed a commit that referenced this pull request Sep 27, 2021
Refs: #36641
Refs: #36617 (comment)
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@mcollina

Copy link
Copy Markdown
Member

Landed in 4b030d0

@dr-js

dr-js commented Oct 5, 2021

Copy link
Copy Markdown
ContributorAuthor

@danielleadams v16 backport PR at: #40321, which is basically previous 9fec6fd

targos added a commit to targos/node that referenced this pull request Oct 5, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2021
Refs: #36670
PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
dr-js added a commit to dr-js/node that referenced this pull request Oct 5, 2021
Refs: nodejs#36641
Refs: nodejs#36617 (comment)
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
dr-js pushed a commit to dr-js/node that referenced this pull request Oct 5, 2021
Refs: nodejs#36670
PR-URL: nodejs#40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Oct 9, 2021
Refs: #36641
Refs: #36617 (comment)
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Oct 9, 2021
Refs: #36670
PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 12, 2021
Refs: #36641
Refs: #36617 (comment)
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 12, 2021
Refs: #36670
PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
2 tasks
BethGriggs added a commit that referenced this pull request Oct 15, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- v8: remove --harmony-top-level-await
(Geoffrey Booth) [#40226]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for th `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 15, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- v8: remove --harmony-top-level-await
(Geoffrey Booth) [#40226]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 16, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support. For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
richardlau added a commit that referenced this pull request Oct 18, 2021
Notable changes:
deps:
* upgrade npm to 8.1.0 (npm team) #40463
doc:
* deprecate (doc-only) http abort related (dr-js) #36670
vm:
* (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249
PR-URL: #40504
@richardlaurichardlau mentioned this pull request Oct 18, 2021
BethGriggs added a commit that referenced this pull request Oct 18, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
BethGriggs added a commit that referenced this pull request Oct 18, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
richardlau added a commit that referenced this pull request Oct 19, 2021
Notable changes:
deps:
* upgrade npm to 8.1.0 (npm team) #40463
doc:
* deprecate (doc-only) http abort related (dr-js) #36670
vm:
* (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249
PR-URL: #40504
BethGriggs added a commit that referenced this pull request Oct 19, 2021
Notable Changes:
Deprecations and Removals:
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup`
options
(Antoine du Hamel) [#39793]
- doc: deprecate (doc-only) http abort related
(dr-js) [#36670]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
OpenSSL 3.0:
Node.js now includes OpenSSL 3.0, specifically https://github.com/quictls/openssl
which provides QUIC support.
While OpenSSL 3.0 APIs should be mostly compatible with those provided
by OpenSSL 1.1.1, we do anticipate some ecosystem impact due to
tightened restrictions on the allowed algorithms and key sizes.
If you hit an `ERR_OSSL_EVP_UNSUPPORTED` error in your application with
Node.js 17, it’s likely that your application or a module you’re using
is attempting to use an algorithm or key size which is no longer allowed
by default with OpenSSL 3.0. A command-line option,
`--openssl-legacy-provider`, has been added to revert to the legacy
provider as a temporary workaround for these tightened restrictions.
For details about all the features in
OpenSSL 3.0 please see https://www.openssl.org/blog/blog/2021/09/07/OpenSSL3.Final.
(Daniel Bevenius) [#38512]
Contributed in #38512, #40478
V8 9.5:
The V8 JavaScript engine is updated to V8 9.5. This release comes with
additional supported types for the `Intl.DisplayNames` API and Extended
`timeZoneName` options in the `Intl.DateTimeFormat` API. You can read
more details in the V8 9.5 release post https://v8.dev/blog/v8-release-95.
(Michaël Zasso) [#40178]
Readline Promise API:
The `readline` module provides an interface for reading data from a
Readable stream (such as `process.stdin`) one line at a time.
(Antoine du Hamel) [#37947]
Other Notable Changes:
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) errors: print Node.js version on fatal exceptions that
cause exit
(Divlo) [#38332]
- deps: upgrade npm to 8.1.0
(npm team) [#40463]
- (SEMVER-MINOR) fs: add FileHandle.prototype.readableWebStream()
(James M Snell) [#39331]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
Semver-Major Commits:
- (SEMVER-MAJOR) build: compile with C++17 (MSVC)
(Richard Lau) [#38807]
- (SEMVER-MAJOR) build: compile with --gnu++17
(Richard Lau) [#38807]
- (SEMVER-MAJOR) deps: update V8 to 9.5.172.19
(Michaël Zasso) [#40178]
- (SEMVER-MAJOR) deps,test,src,doc,tools: update to OpenSSL 3.0
(Daniel Bevenius) [#38512]
- (SEMVER-MAJOR) dgram: tighten `address` validation in `socket.send`
(Voltrex) [#39190]
- (SEMVER-MAJOR) dns: runtime deprecate type coercion of `dns.lookup` options
(Antoine du Hamel) [#39793]
- (SEMVER-MAJOR) dns: default to verbatim=true in dns.lookup()
(treysis) [#39987]
- (SEMVER-MAJOR) doc: update minimum supported FreeBSD to 12.2
(Michaël Zasso) [#40179]
- (SEMVER-MAJOR) errors: disp ver on fatal except that causes exit
(Divlo) [#38332]
- (SEMVER-MAJOR) fs: fix rmsync error swallowing
(Nitzan Uziely) [#38684]
- (SEMVER-MAJOR) fs: aggregate errors in fsPromises to avoid error swallowing
(Nitzan Uziely) [#38259]
- (SEMVER-MAJOR) lib: add structuredClone() global
(Ethan Arrowood) [#39759]
- (SEMVER-MAJOR) lib: expose `DOMException` as global
(Khaidi Chu) [#39176]
- (SEMVER-MAJOR) module: subpath folder mappings EOL
(Guy Bedford) [#40121]
- (SEMVER-MAJOR) module: runtime deprecate trailing slash patterns
(Guy Bedford) [#40117]
- (SEMVER-MAJOR) readline: validate `AbortSignal`s and remove unused event listeners
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: introduce promise-based API
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) readline: refactor `Interface` to ES2015 class
(Antoine du Hamel) [#37947]
- (SEMVER-MAJOR) src: allow CAP\_NET\_BIND\_SERVICE in SafeGetenv
(Daniel Bevenius) [#37727]
- (SEMVER-MAJOR) src: return Maybe from a couple of functions
(Darshan Sen) [#39603]
- (SEMVER-MAJOR) src: allow custom PageAllocator in NodePlatform
(Shelley Vohr) [#38362]
- (SEMVER-MAJOR) stream: fix highwatermark threshold and add the missing error
(Rongjian Zhang) [#38700]
- (SEMVER-MAJOR) stream: don't emit 'data' after 'error' or 'close'
(Robert Nagy) [#39639]
- (SEMVER-MAJOR) stream: do not emit `end` on readable error
(Szymon Marczak) [#39607]
- (SEMVER-MAJOR) stream: forward errored to callback
(Robert Nagy) [#39364]
- (SEMVER-MAJOR) stream: destroy readable on read error
(Robert Nagy) [#39342]
- (SEMVER-MAJOR) stream: validate abort signal
(Robert Nagy) [#39346]
- (SEMVER-MAJOR) stream: unify stream utils
(Robert Nagy) [#39294]
- (SEMVER-MAJOR) stream: throw on premature close in Readable\
(Darshan Sen) [#39117]
- (SEMVER-MAJOR) stream: finished should error on errored stream
(Robert Nagy) [#39235]
- (SEMVER-MAJOR) stream: error Duplex write/read if not writable/readable
(Robert Nagy) [#34385]
- (SEMVER-MAJOR) stream: bypass legacy destroy for pipeline and async iteration
(Robert Nagy) [#38505]
- (SEMVER-MAJOR) url: throw invalid this on detached accessors
(James M Snell) [#39752]
- (SEMVER-MAJOR) url: forbid certain confusable changes from being introduced by toASCII
(Timothy Gu) [#38631]
PR-URL: #40119
richardlau added a commit that referenced this pull request Oct 19, 2021
Notable Changes:
Experimental ESM Loader Hooks API:
Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
1. `resolve`: `resolve` [+ `getFormat`]
2. `load`: `getFormat` + `getSource` + `transformSource`
For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`.
A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.
Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468
Other Notable Changes:
deps:
* upgrade npm to 8.1.0 (npm team) #40463
doc:
* deprecate (doc-only) http abort related (dr-js) #36670
vm:
* (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249
PR-URL: #40504
richardlau added a commit that referenced this pull request Oct 20, 2021
Notable Changes:
Experimental ESM Loader Hooks API:
Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
1. `resolve`: `resolve` [+ `getFormat`]
2. `load`: `getFormat` + `getSource` + `transformSource`
For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`.
A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.
Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468
Other Notable Changes:
deps:
* upgrade npm to 8.1.0 (npm team) #40463
doc:
* deprecate (doc-only) http abort related (dr-js) #36670
vm:
* (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249
PR-URL: #40504
@kanongilkanongil mentioned this pull request Nov 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecationsIssues and PRs related to deprecations.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@dr-js@Trott@ronag@aduh95@mcollina@danielleadams@jasnell@targos@nodejs-github-bot