Skip to content

test: improve test coverage of fs.ReadStream with FileHandle - #40018

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fs-filehandle-stream-coverage
Closed

test: improve test coverage of fs.ReadStream with FileHandle#40018
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fs-filehandle-stream-coverage

Conversation

@aduh95

@aduh95aduh95 commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2021
@targos

targos commented Sep 18, 2021

Copy link
Copy Markdown
Member

@nodejs/fs

@targostargos added the fs Issues and PRs related to the fs subsystem / file system. label Sep 18, 2021
@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 26, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2021
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40076/

@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40081/

This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 4, 2021
Open
Open
Open
@LxxyxLxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40174/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40176/

@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2021
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40190/

This was referenced Oct 8, 2021
Open
Open
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions

github-actionsBot commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

Landed in eb65871...1d84e91

nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
@aduh95@nodejs-github-bot
test: improve test coverage of fs.ReadStream with FileHandle
1d84e91
PR-URL: #40018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95
aduh95 deleted the fs-filehandle-stream-coverage branch October 9, 2021 17:16
This was referenced Oct 10, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Oct 13, 2021
@aduh95@targos
test: improve test coverage of fs.ReadStream with FileHandle
13d6a56
PR-URL: #40018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlaurichardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@LxxyxLxxyxLxxyx approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@targos@nodejs-github-bot@jasnell@Lxxyx