Uh oh!
There was an error while loading. Please reload this page.
v16.12.0 proposal - #40504
Merged
Merged
Conversation
Main changes: - Replace current HTML anchor generation to match header anchor generation in Github markdown. - Remove unnecessary double namespacing on generated anchors/links (E.G. `esm.md#loaders` instead of `esm.md#esm_loaders`). - Anchors/links are automatically prefixed with their respective modules when concatenated for usage in `all.html`. Benefits: - All anchor links within and between markdown API docs actually work. - Adding new anchor links no longer requires contributors to generate the HTML docs first to look up the correct anchors. - Anchors are much shorter. - All previous anchor links are preserved by generating hidden legacy anchors. PR-URL: #39304 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
doc: update ESM hook examples esm: fix unsafe primordial doc: fix ESM example linting esm: allow source of type ArrayBuffer doc: update ESM hook changelog to include resolve format esm: allow all ArrayBuffers and TypedArrays for load hook source doc: tidy code & API docs doc: convert ESM source table header from Title Case to Sentence case doc: add detailed explanation for getPackageType esm: add caveat that ESMLoader::import() must NOT be renamed esm: tidy code declaration of getFormat protocolHandlers doc: correct ESM doc link (bad conflict resolution) doc: update ESM hook limitation for CJS esm: tweak preload description doc: update ESM getPackageType() example explanation PR-URL: #37468 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #40226 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Refs: #36641 Refs: #36617 (comment) Documentation-only deprecate `.aborted` property and `'abort'`, `'aborted'` event in `http`, and suggest using the corresponding Stream API instead. Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #36670 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: #37468 PR-URL: #40275 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
_subpath_ is not defined in this context. This is pretty clearly meant to be _packageSubpath_, which is the second argument to `PACKAGE_SELF_RESOLVE` PR-URL: #40273 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
PR-URL: #40249 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40355 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
PR-URL: #40255 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #40304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into a single entry. PR-URL: #40367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40358 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40018 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: #40252 (review) PR-URL: #40359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
move variable into each for loop PR-URL: #40364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry. PR-URL: #40387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
commented
Oct 19, 2021
MemberAuthor
What would be really helpful is one or two sentences to go in the Notable changes section that explains why the change is notable for anyone reading the changelog. Otherwise we'll just have the following, which really doesn't suggest "This is a very notable change, as it changes how loader hooks work and deprecates the previous system." (maybe the sentence is "Changes the way loader hooks work and deprecates the previous system."?) Notable Changes
|
JakobJingleheimer
commented
Oct 19, 2021
Member
gah, sorry. I dunno how that messed up on my laptop (I just fixed it in my git global config). I'll look into the mailmap this week.
thank you!
okay! I shall send over this evening. |
JakobJingleheimer
commented
Oct 19, 2021
Member
How about something like this: Experimental ESM Loader Hooks APINode.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
For consistency, A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 |
shrujalshah28 added a commit
to shrujalshah28/ts-node
that referenced
this pull request
Oct 19, 2021
shrujalshah28 added a commit
to shrujalshah28/ts-node
that referenced
this pull request
Oct 19, 2021
Notable Changes: Experimental ESM Loader Hooks API: Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining: 1. `resolve`: `resolve` [+ `getFormat`] 2. `load`: `getFormat` + `getSource` + `transformSource` For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`. A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 Other Notable Changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504
richardlauforce-pushed
the
v16.12.0-proposal
branch
from
October 19, 2021 21:13
4774eaf to
4941550CompareMemberAuthor
I've updated the notable changes PTAL. I've also bumped the date to tomorrow as it's late here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
27 tasks
Collaborator
danbev
approved these changes
Oct 20, 2021
BethGriggs
approved these changes
Oct 20, 2021
richardlau added a commit
that referenced
this pull request
Oct 20, 2021
Notable Changes: Experimental ESM Loader Hooks API: Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining: 1. `resolve`: `resolve` [+ `getFormat`] 2. `load`: `getFormat` + `getSource` + `transformSource` For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`. A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 Other Notable Changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504
richardlau added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 20, 2021
richardlau added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 20, 2021
30 tasks
cspotcode pushed a commit
to TypeStrong/ts-node
that referenced
this pull request
Oct 21, 2021
* update version checks for v16 Ref: nodejs/node#40504 * add test to check old ESM Loader Hooks API on v16.11.1 * fix wrong version number
This was referenced Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick release to clear the 50+ commits that are currently unreleased on v16.x-staging ahead of next week's LTS transition (where traditionally we only flip the LTS bit in those). Originally there was a planned regular 16 release for last week but that didn't happen because of the security releases that week.
This is intended to be the last "current" release of Node.js 16 and we'll expect future changes to 16 to be made under LTS guidelines.
2021-10-20, Version 16.12.0 (Current), @richardlau
Notable Changes
Experimental ESM Loader Hooks API
Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
resolve:resolve[+getFormat]load:getFormat+getSource+transformSourceFor consistency,
getGlobalPreloadCodehas been renamed toglobalPreload.A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.
Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468
Other Notable Changes
8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #366704116b6c907] - (SEMVER-MINOR)vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249Commits
8bb3951e41] - build: remove duplicate check for authors.yml (Rich Trott) #403932de57edced] - build: make scripts in gyp run with right python (Cheng Zhao) #39730a8926d199d] - crypto: remove incorrect constructor invocation (gc) #403008fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463dca5ac1539] - deps: suppress zlib compiler warnings (Daniel Bevenius) #4034391c3bf6a7f] - deps: upgrade Corepack to 0.10 (Maël Nison) #403747e02124a06] - dgram: addnreadassertion toUDPWrap::OnRecv(Darshan Sen) #402952d409ed29e] - dns: refactor and use validators (Voltrex) #40022dc7291dab8] - doc: remove ESLint comments which were breaking the CJS/ESM toggles (Mark Skelton) #4040885b7385115] - doc: add pronouns for tniessen to README (Tobias Nießen) #404121d5857c9f4] - doc: format changelogs (Rich Trott) #403885eb9402b50] - doc: fix missing variable in deepStrictEqual example (OliverOdo) #403966f77d1a1d5] - doc: fix asyncLocalStorage.run() description (Constantine Kim) #4038193a48e02dc] - doc: fix typos in n-api docs (Ignacio Carbajo) #40402fb7afb91c2] - doc: format doc/guides using format-md task (Rich Trott) #403586c091c7878] - doc: improve phrasing in fs.md (Arslan Ali) #4025538d81380ac] - doc: add link to core promises tracking issue (Michael Dawson) #4035571a94aa82a] - doc: correct ESM load hook table header (Jacob Smith) #402345b074affb4] - doc: fix typo in esm.md (Mason Malone) #402733b3aaa0a37] - doc: fix typo in ESM example (Tobias Nießen) #40275f848553fb8] - doc: assign missing deprecation number (Michaël Zasso) #40324d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #366701ef2cf8413] - doc: anchor link parity between markdown and html-generated docs (foxxyz) #393043743406b0a] - (SEMVER-MINOR)esm: consolidate ESM loader hooks (Jacob Smith) #37468168020e1c8] - lib: refactor to use let (gdccwxx) #40364bcd59d70bb] - meta: consolidate AUTHORS entries for gabrielschulhof (Rich Trott) #4042080b4245db8] - meta: consolidate AUTHORS information for geirha (Rich Trott) #4040693cecb4700] - meta: consolidate duplicate AUTHORS entries for hassaanp (Rich Trott) #40391fff3135909] - meta: update AUTHORS (Node.js GitHub Bot) #40392122481713d] - meta: consolidate AUTHORS entry for thw0rted (Rich Trott) #403877f50313fcc] - meta: update label-pr-config (Mestery) #401995668182665] - meta: use .mailmap to consolidate AUTHORS entries for ide (Rich Trott) #40367bc86084a3e] - net: check if option is undefined (Daijiro Wachi) #403444564a93e5e] - net: remove unused ObjectKeys (Daijiro Wachi) #40344dbb2e6f429] - net: check objectMode first and then readble || writable (Daijiro Wachi) #40344a672be57c8] - net: throw error to object mode in Socket (Daijiro Wachi) #40344faf9e28c36] - src: remove usage ofAllocatedBufferfromstream_*(Darshan Sen) #40293857af2ba99] - src: add missing initialization (Michael Dawson) #403702bfa87edbc] - stream: fix fromAsyncGen (Robert Nagy) #404991e15137e71] - test: replace common port with specific number (Daijiro Wachi) #403446f6b99c302] - test: fix typos in whatwg-webstreams explanations (Tobias Nießen) #40389641b1bb052] - test: add test for readStream.path when fd is specified (Qingyu Deng) #4035907dae7ff50] - test: replace .then chains with await (gdccwxx) #40348d8a36ee1de] - test: fix "test/common/debugger" identify async function (gdccwxx) #4034813d6a56c7d] - test: improve test coverage offs.ReadStreamwithFileHandle(Antoine du Hamel) #4001850f91ab059] - tools: udpate @babel/eslint-parser (Rich Trott) #403943611073145] - tools: remove @babel/plugin-syntax-import-assertions (Rich Trott) #40394b72d693a3a] - tools: remove @bable/plugin-syntax-class-properties (Rich Trott) #40394d6a99b77da] - tools: remove @babel/plugin-syntax-top-level-await (Rich Trott) #40394d9157aa5fe] - tools: update ESLint to 8.0.0 (Rich Trott) #4039443b97c7984] - tools: prepare ESLint rules for 8.0.0 requirements (Rich Trott) #40394282b6eb4b0] - tools: fix ESLint update scripts (Rich Trott) #40394c3a744f7bf] - tools: warn about duplicates when generating AUTHORS file (Rich Trott) #403047733b5e55d] - typings: define types for os binding (Michaël Zasso) #40222ca9a854877] - typings: add missing types to options and util bindings (Michaël Zasso) #40222c3a7a0bd59] - typings: define types for timers binding (Michaël Zasso) #4022265b51d05fa] - typings: fix declaration of primordials (Michaël Zasso) #402225f3f3a5128] - v8: remove --harmony-top-level-await (Geoffrey Booth) #402264116b6c907] - (SEMVER-MINOR)vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249