Uh oh!
There was an error while loading. Please reload this page.
test: fix cluster-disconnect-handles flakiness - #4009
Closed
santigimeno wants to merge 1 commit into
Closed
Conversation
Member
There was a problem hiding this comment.
Wouldn't it be better to rewrite the protocol.onResponse logic to wait for the break event first before sending the continue command?
Thanks for looking into this, by the way. Looks like this might fix #3907.
santigimenoforce-pushed
the
fix-test-cluster-disconnect-handles
branch
from
November 25, 2015 09:21
8301a40 to
d90a4f5Comparesantigimeno
commented
Nov 25, 2015
MemberAuthor
@bnoordhuis updated using |
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end.
santigimenoforce-pushed
the
fix-test-cluster-disconnect-handles
branch
from
November 25, 2015 10:36
d90a4f5 to
1226417Comparebnoordhuis
commented
Nov 25, 2015
Member
bnoordhuis
commented
Dec 1, 2015
Member
Thanks Santiago, landed in 8677627. |
bnoordhuis pushed a commit
that referenced
this pull request
Dec 1, 2015
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: #4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit
that referenced
this pull request
Dec 5, 2015
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: #4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Dec 8, 2015
MylesBorins pushed a commit
that referenced
this pull request
Dec 15, 2015
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: #4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
jasnell pushed a commit
that referenced
this pull request
Dec 17, 2015
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: #4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit
that referenced
this pull request
Dec 23, 2015
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: #4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: nodejs#4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the test was timing out because the worker process remained stuck in
the breakpoint and didn't exit. This could happen because the continue was sent
before the breakpoint was set. If that's the case, with this change, a new
continue command is sent so the worker process can end.
It fixes for me the following error I was receiving in a
Jessie 64bitbox: