Uh oh!
There was an error while loading. Please reload this page.
test: improve cluster-disconnect-handles test - #4084
Conversation
mscdex
commented
Dec 1, 2015
CI is all green except unrelated errors on Windows. |
There was a problem hiding this comment.
Hmm... is this the only test that suffers from this problem?
There was a problem hiding this comment.
I don't know, but this was the only one I personally saw that was causing this problem.
cjihrig
commented
Dec 1, 2015
LGTM with a question and comment. |
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available.
73d2dd4 to
e22c756Comparecjihrig
commented
Dec 1, 2015
mscdex
commented
Dec 1, 2015
@cjihrig I don't know, that might be a separate issue. This is what I get when I don't have the IPv6 check in place: |
cjihrig
commented
Dec 1, 2015
Does listening on |
mscdex
commented
Dec 1, 2015
It would probably work for me because I only have |
cjihrig
commented
Dec 1, 2015
OK, I don't want to hold up this PR, I was just looking for a cleaner alternative. |
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available. PR-URL: #4084 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdex
commented
Dec 2, 2015
Landed in 49b5445. |
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available. PR-URL: #4084 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available. PR-URL: #4084 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available. PR-URL: #4084 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit fixes two issues in
test-cluster-disconnect-handles:EADDRINUSE).