Skip to content

doc: fix typo in esm.md - #40273

Closed
MasonM wants to merge 1 commit into
nodejs:masterfrom
MasonM:patch-2
Closed

doc: fix typo in esm.md#40273
MasonM wants to merge 1 commit into
nodejs:masterfrom
MasonM:patch-2

Conversation

@MasonM

@MasonMMasonM commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

subpath is not defined in this context. This is pretty clearly meant to be packageSubpath, which is the second argument to PACKAGE_SELF_RESOLVE

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 1, 2021
@MasonM
doc: fix typo in esm.md
85d1f7e
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
@aduh95
aduh95 requested a review from guybedfordOctober 1, 2021 08:10
guybedford
guybedford approved these changes Oct 1, 2021
View reviewed changes

@guybedfordguybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2021
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions

github-actionsBot commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

Landed in 3d11baf...03d25fe

nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
@MasonM@nodejs-github-bot
doc: fix typo in esm.md
03d25fe
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@MasonM@danielleadams
doc: fix typo in esm.md
3923972
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 4, 2021
Merged
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@MasonM@danielleadams
doc: fix typo in esm.md
57d3f4b
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams

danielleadams commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Added dont-land-on-v16.x label and waiting for #37468 before ready for v16.x.

targos pushed a commit that referenced this pull request Oct 9, 2021
@MasonM@targos
doc: fix typo in esm.md
daa61b4
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 12, 2021
@MasonM@danielleadams
doc: fix typo in esm.md
5b074af
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`
PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlaurichardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@guybedfordguybedfordguybedford approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@MasonM@danielleadams@jasnell@guybedford@lpinca@tniessen@aduh95@targos@nodejs-github-bot