Skip to content

src: remove usage of AllocatedBuffer from stream_* - #40293

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:src/remove-usage-of-AllocatedBuffer-from-stream
Closed

src: remove usage of AllocatedBuffer from stream_*#40293
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:src/remove-usage-of-AllocatedBuffer-from-stream

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Oct 3, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Darshan Sen darshan.sen@postman.com

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 3, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2021
addaleax
addaleax approved these changes Oct 6, 2021
View reviewed changes
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/stream_pipe.cc Outdated
Comment threadsrc/stream_base.cc Outdated
@RaisinTenRaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2021
@RaisinTen
src: remove usage of AllocatedBuffer from stream_*
9ed6888
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen
RaisinTenforce-pushed the src/remove-usage-of-AllocatedBuffer-from-stream branch from d111e66 to 9ed6888CompareOctober 8, 2021 15:56
RaisinTen
RaisinTen commented Oct 8, 2021
View reviewed changes
Comment threadsrc/stream_base.cc
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Oct 9, 2021
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40228/

This was referenced Oct 10, 2021
Open
Open
@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2021
@Mesteery

Mesteery commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@RaisinTen The PR didn't land because the CI was running. I think you could remove the commit-queue label and put it back.

pr 40293 skipped, CI still running

https://github.com/nodejs/node/runs/3863311768?check_suite_focus=true#step:8:46

@targos

targos commented Oct 12, 2021

Copy link
Copy Markdown
Member

I think we'll have to land this one manually. Sometimes GitHub's API reports pending checks that don't exist.

RaisinTen added a commit that referenced this pull request Oct 12, 2021
@RaisinTen
src: remove usage of AllocatedBuffer from stream_*
a784258
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #40293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen

RaisinTen commented Oct 12, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in a784258

@RaisinTen
RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-stream branch October 12, 2021 05:58
@RaisinTenRaisinTen removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actionsgithub-actionsBot mentioned this pull request Oct 13, 2021
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 13, 2021
@RaisinTen@targos
src: remove usage of AllocatedBuffer from stream_*
faf9e28
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #40293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Oct 14, 2021
Open
22 tasks
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
This was referenced Oct 15, 2021
Open
Open
@richardlaurichardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen@nodejs-github-bot@Mesteery@targos@jasnell@addaleax