Skip to content

test: fix typos in whatwg-webstreams explanations - #40389

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-typos-whatwg-webstreams-transfer-transfered
Closed

test: fix typos in whatwg-webstreams explanations#40389
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-typos-whatwg-webstreams-transfer-transfered

Conversation

@tniessen

Copy link
Copy Markdown
Member

No description provided.

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 9, 2021
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 9, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 9, 2021
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40389
✔ Done loading data for nodejs/node/pull/40389
----------------------------------- PR info ------------------------------------
Title test: fix typos in whatwg-webstreams explanations (#40389)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch tniessen:test-typos-whatwg-webstreams-transfer-transfered -> nodejs:master
Labels test, fast-track, author ready
Commits 1
- test: fix typos in whatwg-webstreams explanations
Committers 1
- GitHub PR-URL: https://github.com/nodejs/node/pull/40389
Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40389
Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel --------------------------------------------------------------------------------
ℹ This PR was created on Sat, 09 Oct 2021 16:45:03 GMT
✔ Approvals: 2
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40389#pullrequestreview-775593853
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40389#pullrequestreview-775594008
ℹ This PR is being fast-tracked
✔ Last GitHub Actions successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1324128655

@github-actionsgithub-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 9, 2021
@tniessentniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 9, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 92090d3...8068f40

nodejs-github-bot pushed a commit that referenced this pull request Oct 10, 2021
PR-URL: #40389
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
PR-URL: #40389
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
2 tasks
@richardlaurichardlau mentioned this pull request Oct 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@Trott@lpinca@cjihrig@aduh95