Skip to content

meta: consolidate duplicate AUTHORS entries for hassaanp - #40391

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-hp
Closed

meta: consolidate duplicate AUTHORS entries for hassaanp#40391
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-hp

Conversation

@Trott

@TrottTrott commented Oct 9, 2021

Copy link
Copy Markdown
Member

Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.

Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 9, 2021
@Trott

Trott commented Oct 9, 2021

Copy link
Copy Markdown
MemberAuthor

@hassaanp This removes your team.io email from AUTHORS and leaves your gmail.com address. If you'd prefer it the other way around, please leave a comment. Thanks!

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 9, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@hassaanp

Copy link
Copy Markdown
Contributor

Please go ahead. Thanks

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2021
@LxxyxLxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 66da32c...0cc3720

nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2021
Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.
PR-URL: #40391
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott
Trott deleted the authors-hp branch October 11, 2021 13:18
targos pushed a commit that referenced this pull request Oct 13, 2021
Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.
PR-URL: #40391
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
2 tasks
@richardlaurichardlau mentioned this pull request Oct 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@hassaanp@tniessen@Lxxyx@nodejs-github-bot@Mesteery