Skip to content

stream: return readable stream on promisified pipeline - #40653

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:promise-pipeline-return
Closed

stream: return readable stream on promisified pipeline#40653
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:promise-pipeline-return

Conversation

@ronag

@ronagronag commented Oct 29, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Otherwise it's impossible to read the remaining data...

@ronag
ronag requested review from lpinca and mcollinaOctober 29, 2021 10:50
@ronagronag added semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem. labels Oct 29, 2021
@ronag

ronag commented Oct 29, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021
@ronag
ronagforce-pushed the promise-pipeline-return branch from 56ec619 to 088af2aCompareOctober 29, 2021 10:51
@ronagronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
@ronag

ronag commented Oct 29, 2021

Copy link
Copy Markdown
MemberAuthor

@mcollina semver minor or major? wdyt?

Mesteery
Mesteery reviewed Oct 29, 2021
View reviewed changes
Comment threadtest/parallel/test-stream-pipeline.js
@ronagronag mentioned this pull request Oct 29, 2021
Closed
@ronagronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
lpinca
lpinca reviewed Oct 31, 2021
View reviewed changes
Comment threadlib/stream/promises.js Outdated
@ronagronag mentioned this pull request Nov 1, 2021
Open
@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 4, 2021
@ronag
ronagforce-pushed the promise-pipeline-return branch from aea84c2 to 088af2aCompareNovember 4, 2021 20:57
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40715/

mcollina
mcollina requested changes Nov 4, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the docs?

This was referenced Nov 5, 2021
Open
Open
Open
@ronagronag closed this Nov 7, 2021
@ronag

ronag commented Nov 7, 2021

Copy link
Copy Markdown
MemberAuthor

Probably better to just use stream.compose in this scenario.

@github-actionsgithub-actionsBot mentioned this pull request Nov 8, 2021
Open
46 tasks
@joyeecheungjoyeecheung mentioned this pull request Nov 8, 2021
Closed
This was referenced Nov 9, 2021
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca left review comments
@mcollinamcollinamcollina requested changes
+1 more reviewer
@MesteeryMesteeryMesteery left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-majorPRs that contain breaking changes and should be released in the next major version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag@nodejs-github-bot@mcollina@lpinca@Mesteery