Skip to content

stream: pipeline should drain empty readable - #40654

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:drain-empty-readable
Closed

stream: pipeline should drain empty readable#40654
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:drain-empty-readable

Conversation

@ronag

@ronagronag commented Oct 29, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This simplifies some cases where the last stream is a Duplex
without any expected output.

awaitpipeline(readable,duplex)

Related: #40653

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Oct 29, 2021
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021
@ronag

ronag commented Oct 29, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@ronag
ronagforce-pushed the drain-empty-readable branch from 9e5a829 to 8d15eb2CompareOctober 29, 2021 11:25
@ronag
ronag requested a review from mcollinaOctober 29, 2021 11:25
@ronagronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
mcollina
mcollina approved these changes Oct 29, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40589/

This was referenced Nov 1, 2021
Open
Open
Open
@ronag
ronag requested a review from jasnellNovember 4, 2021 20:53
@nodejs-github-bot

nodejs-github-bot commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40714/

@github-actionsgithub-actionsBot mentioned this pull request Nov 5, 2021
Open
43 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40729/

mcollina
mcollina approved these changes Nov 5, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag

ronag commented Nov 5, 2021

Copy link
Copy Markdown
MemberAuthor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2789/

This was referenced Nov 6, 2021
Open
Open
Open
Open
Open
@ronag
ronag requested a review from lpincaNovember 10, 2021 15:23
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40821/

@github-actionsgithub-actionsBot mentioned this pull request Nov 12, 2021
Open
35 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40846/

@github-actionsgithub-actionsBot mentioned this pull request Nov 13, 2021
Open
31 tasks
@ronag

ronag commented Nov 13, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/tsc this needs another TSC approval

@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40863/

@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2021
Open
41 tasks
@Trott

Trott commented Nov 14, 2021

Copy link
Copy Markdown
Member

This needs a rebase against the master branch for one of the tests to pass on the Pi devices.

@ronag
stream: pipeline should drain empty readable
181bdf9
This simplifies some cases where the last stream is a Duplex
without any expected output.
await pipeline(readable, duplex)
@ronag
ronagforce-pushed the drain-empty-readable branch from 8d15eb2 to 181bdf9CompareNovember 14, 2021 13:51
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40881/

@github-actionsgithub-actionsBot mentioned this pull request Nov 15, 2021
Open
44 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40898/

@github-actionsgithub-actionsBot mentioned this pull request Nov 16, 2021
Open
40 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40923/

This was referenced Nov 17, 2021
Open
Open
@ronagronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 18, 2021
@ronag

ronag commented Nov 18, 2021

Copy link
Copy Markdown
MemberAuthor

@mcollina I don't think this should be semver-major. wdyt?

mcollina
mcollina approved these changes Nov 18, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ok

@ronag

ronag commented Nov 18, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 0a3a601

@ronagronag closed this Nov 18, 2021
ronag added a commit that referenced this pull request Nov 18, 2021
@ronag
stream: pipeline should drain empty readable
0a3a601
This simplifies some cases where the last stream is a Duplex
without any expected output.
await pipeline(readable, duplex)
PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 19, 2021
Open
31 tasks
targos pushed a commit that referenced this pull request Nov 21, 2021
@ronag@targos
stream: pipeline should drain empty readable
16ee842
This simplifies some cases where the last stream is a Duplex
without any expected output.
await pipeline(readable, duplex)
PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag@danielleadams
stream: pipeline should drain empty readable
644b9a9
This simplifies some cases where the last stream is a Duplex
without any expected output.
await pipeline(readable, duplex)
PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag@danielleadams
stream: pipeline should drain empty readable
c9f1398
This simplifies some cases where the last stream is a Duplex
without any expected output.
await pipeline(readable, duplex)
PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@Trott@mcollina@benjamingr@lpinca