tools: update babel-eslint-parser to 7.16.0 by Trott · Pull Request #40720 · nodejs/node

Trott · 2021-11-04T05:41:28Z

No description provided.

targos · 2021-11-04T12:28:57Z

Looks like some files have to be fixed.

targos · 2021-11-04T14:45:16Z

s/will be flagged when we flagged when we/will be flagged when we/

github-actions · 2021-11-06T12:58:55Z

Commit Queue failed

- Loading data for nodejs/node/pull/40720
✔ Done loading data for nodejs/node/pull/40720
----------------------------------- PR info ------------------------------------
Title tools: update babel-eslint-parser to 7.16.0 (#40720)
Author Rich Trott (@Trott)
Branch Trott:bep-7.16 -> nodejs:master
Labels tools, author ready
Commits 2
- test: add semicolons for linter update
- tools: update babel-eslint-parser to 7.16.0
Committers 1
- Rich Trott PR-URL: https://github.com/nodejs/node/pull/40720
Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40720
Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 04 Nov 2021 05:41:28 GMT
✔ Approvals: 3
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40720#pullrequestreview-797837612
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40720#pullrequestreview-797840350
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40720#pullrequestreview-798182790
✔ Last GitHub Actions successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1429133588

nodejs-github-bot · 2021-11-06T13:14:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40742/

nodejs-github-bot · 2021-11-06T19:54:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40744/

nodejs-github-bot · 2021-11-06T23:56:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40745/

nodejs-github-bot · 2021-11-07T16:05:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40754/

nodejs-github-bot · 2021-11-08T01:52:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40756/

nodejs-github-bot · 2021-11-08T03:04:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40757/

nodejs-github-bot · 2021-11-08T03:56:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40758/

nodejs-github-bot · 2021-11-08T04:32:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40759/

nodejs-github-bot · 2021-11-08T05:29:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40760/

nodejs-github-bot · 2021-11-08T12:08:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40772/

nodejs-github-bot · 2021-11-08T14:05:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40776/

Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2021-11-08T21:16:54Z

Landed in 04451d8...9ef0ae2

Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: #40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams · 2022-01-30T06:29:15Z

@Trott do you mind backporting this to 16.x? When I tried to land in 16.x-staging, there was a test that didn't pass.

Trott · 2022-01-30T14:47:40Z

@Trott do you mind backporting this to 16.x? When I tried to land in 16.x-staging, there was a test that didn't pass.

@danielleadams Backported in #41770

Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: #40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Backport-PR-URL: #41770 Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

PR-URL: #40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Backport-PR-URL: #41770 Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 4, 2021

Trott force-pushed the bep-7.16 branch from 97470c4 to e5e6bf9Compare November 4, 2021 13:21

tniessen approved these changes Nov 4, 2021
View reviewed changes

targos approved these changes Nov 4, 2021
View reviewed changes

Trott force-pushed the bep-7.16 branch from e5e6bf9 to c7bc202Compare November 4, 2021 15:46

nodejs deleted a comment Nov 4, 2021

lpinca approved these changes Nov 4, 2021
View reviewed changes

Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 4, 2021

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 6, 2021

targos mentioned this pull request Nov 6, 2021
tools: update ESLint to 8.2.0 #40734
Closed

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021

github-actionsBot mentioned this pull request Nov 7, 2021
CI Reliability 2021-11-07 nodejs/reliability#110
Open
46 tasks

github-actionsBot mentioned this pull request Nov 8, 2021
CI Reliability 2021-11-08 nodejs/reliability#111
Open
46 tasks

Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2021

Trott added 2 commits November 8, 2021 13:16

tools: update babel-eslint-parser to 7.16.0
9ef0ae2
PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott force-pushed the bep-7.16 branch from c7bc202 to 9ef0ae2Compare November 8, 2021 21:16

Trott closed this Nov 8, 2021

Trott deleted the bep-7.16 branch November 8, 2021 21:17

targos pushed a commit that referenced this pull request Nov 21, 2021
tools: update babel-eslint-parser to 7.16.0
5b08e90
PR-URL: #40720 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Nov 26, 2021
v17.2.0 release proposal #40983
Merged

danielleadams added the backport-requested-v16.x label Jan 30, 2022

danielleadams mentioned this pull request Jan 30, 2022
tools: update @babel/eslint-parser to 7.16.3 #40889
Merged

Trott mentioned this pull request Jan 30, 2022
[v16.x backport] tools: update babel-eslint-parser to 7.16.0 #41770
Closed

danielleadams added backported-to-v16.x and removed backport-requested-v16.x labels Feb 1, 2022

danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged

Uh oh!

Uh oh!

Conversation

Trott commented Nov 4, 2021

Uh oh!

targos commented Nov 4, 2021

Uh oh!

targos commented Nov 4, 2021

Uh oh!

github-actionsBot commented Nov 6, 2021

Uh oh!

nodejs-github-bot commented Nov 6, 2021

Uh oh!

nodejs-github-bot commented Nov 6, 2021

Uh oh!

nodejs-github-bot commented Nov 6, 2021

Uh oh!

nodejs-github-bot commented Nov 7, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

nodejs-github-bot commented Nov 8, 2021

Uh oh!

Trott commented Nov 8, 2021

Uh oh!

danielleadams commented Jan 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Jan 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danielleadams commented Jan 30, 2022•
edited
Loading