Skip to content

[v16.x backport] tools: update babel-eslint-parser to 7.16.0 - #41770

Closed
Trott wants to merge 2 commits into
nodejs:v16.x-stagingfrom
Trott:backport-1
Closed

[v16.x backport] tools: update babel-eslint-parser to 7.16.0#41770
Trott wants to merge 2 commits into
nodejs:v16.x-stagingfrom
Trott:backport-1

Conversation

@Trott

Copy link
Copy Markdown
Member

Backport of #40720

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Jan 30, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@danielleadamsdanielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 31, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@danielleadams

Copy link
Copy Markdown
Contributor

@Trott sorry - I had to do a hard rebase. are you able to drop the additional commits? I will hold the branch until I land this. Thank you!

Add missing semicolons that will be flagged when we update
@babel/eslint-parser to 7.16.0.
PR-URL: nodejs#40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

@Trott sorry - I had to do a hard rebase. are you able to drop the additional commits? I will hold the branch until I land this. Thank you!

All done!

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Add missing semicolons that will be flagged when we update
@babel/eslint-parser to 7.16.0.
PR-URL: #40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: #41770
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: #41770
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@danielleadams

Copy link
Copy Markdown
Contributor

Landed in 4e05026...ea75ef5

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@danielleadams@lpinca