build: ignore unrelated workflow changes in slow Actions tests by Trott · Pull Request #40928 · nodejs/node

Trott · 2021-11-22T22:58:08Z

test-asan and test-macos are very slow and tend to get backed up. While
I'm literally waiting hours right now for test-macos to finish so I can
land a PR, I'm opening this pull request to have it be skipped when
things other than its own workflow file are the only changes in the PR.

aduh95

tbh we could do that for all the workflow files

tniessen

LGTM modulo @richardlau's comment

Trott · 2021-11-23T03:30:56Z

tbh we could do that for all the workflow files

Perhaps all the test-* files. We don't want to do it for the one that lints the commit message, for example.

Trott · 2021-11-23T03:31:32Z

Refactored to use paths instead of paths-ignore. Did I do it right?

Trott · 2021-11-23T03:53:53Z

Per suggestion from @aduh95, I've also put this into test-linux.yml.

Trott · 2021-11-23T04:00:46Z

I'm concerned that the way I did this means that everything matches except the last negation.

Trott · 2021-11-23T05:32:51Z

I'm concerned that the way I did this means that everything matches except the last negation.

OK, I think what I have now should work.

targos · 2021-11-23T07:56:11Z

test-asan and test-macos are very slow and tend to get backed up

I think this is my fault. See #40934

Trott · 2021-11-25T21:08:08Z

OK, i think this will work and addresses all comments. Re-reviews welcome!

test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR.

nodejs-github-bot · 2021-11-27T01:18:38Z

Landed in e64c66c

Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: nodejs#40928

Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 22, 2021

aduh95 approved these changes Nov 23, 2021
View reviewed changes

richardlau reviewed Nov 23, 2021
View reviewed changes

Comment thread.github/workflows/test-asan.yml Outdated

tniessen approved these changes Nov 23, 2021
View reviewed changes

Trott force-pushed the skip-macos branch 2 times, most recently from 45dbbce to 5b94831Compare November 23, 2021 03:53

Trott force-pushed the skip-macos branch from 5b94831 to fb1044aCompare November 23, 2021 05:32

aduh95 reviewed Nov 23, 2021
View reviewed changes

Comment thread.github/workflows/test-linux.yml Outdated

Mesteery reviewed Nov 23, 2021
View reviewed changes

Comment thread.github/workflows/test-asan.yml Outdated

Trott force-pushed the skip-macos branch from fb1044a to 575837cCompare November 25, 2021 21:07

Trott force-pushed the skip-macos branch from 575837c to fb1044aCompare November 26, 2021 03:21

Trott force-pushed the skip-macos branch from fb1044a to 25e1067Compare November 26, 2021 03:27

aduh95 approved these changes Nov 26, 2021
View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021

nodejs-github-bot merged commit e64c66c into nodejs:masterNov 27, 2021

aduh95 added a commit to aduh95/node that referenced this pull request Nov 27, 2021
tools: ignore unrelated workflow changes in slow Actions tests
5205d66
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: nodejs#40928

aduh95 mentioned this pull request Nov 27, 2021
tools: ignore unrelated workflow changes in slow Actions tests #40990
Merged

danielleadams mentioned this pull request Dec 14, 2021
v17.3.0 release proposal #41167
Merged

danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged

Trott deleted the skip-macos branch September 25, 2022 17:12

Navigation Menu

Uh oh!

Uh oh!

build: ignore unrelated workflow changes in slow Actions tests - #40928

build: ignore unrelated workflow changes in slow Actions tests#40928
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:skip-macos

Trott commented Nov 22, 2021

Uh oh!

aduh95 left a comment

Uh oh!

Uh oh!

tniessen left a comment

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

targos commented Nov 23, 2021

Uh oh!

Uh oh!

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

nodejs-github-bot commented Nov 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

Trott commented Nov 22, 2021

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

Trott commented Nov 23, 2021

Uh oh!

targos commented Nov 23, 2021

Uh oh!

Uh oh!

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

nodejs-github-bot commented Nov 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants