Skip to content

tools: update gyp-next to v0.10.1 - #40934

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
targos:gyp-make-toolset
Nov 26, 2021
Merged

tools: update gyp-next to v0.10.1#40934
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
targos:gyp-make-toolset

Conversation

@targos

@targostargos commented Nov 23, 2021

Copy link
Copy Markdown
Member

This should fix the regression in compilation times after #40488
I'll upstream to gyp-next if it works.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v12.x gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41051/

@targostargos mentioned this pull request Nov 23, 2021
Merged
@targos

targos commented Nov 23, 2021

Copy link
Copy Markdown
MemberAuthor

I think it works.

targos added a commit to nodejs/gyp-next that referenced this pull request Nov 23, 2021
@targos
fix(make): only generate makefile for multiple toolsets if requested
8ace701
It's already like this in the msvs and ninja generators.
Refs: nodejs/node#40934
@targostargos mentioned this pull request Nov 23, 2021
Merged
@github-actionsgithub-actionsBot mentioned this pull request Nov 24, 2021
Open
45 tasks
targos added a commit to nodejs/gyp-next that referenced this pull request Nov 24, 2021
@targos
fix(make): only generate makefile for multiple toolsets if requested (#…
f463a77
…133)
It's already like this in the msvs and ninja generators.
Refs: nodejs/node#40934
@targostargos changed the title [dont-land] tools: only generate makefile for multiple toolsets if requestedtools: update gyp-next to v0.10.1Nov 24, 2021
@targostargos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2021
@github-actions

github-actionsBot commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41073/

@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41075/

@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41078/

@github-actionsgithub-actionsBot mentioned this pull request Nov 25, 2021
Open
38 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41099/

@richardlaurichardlau mentioned this pull request Nov 25, 2021
Closed
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41109/ (✔️ 🎉 )

@github-actionsgithub-actionsBot mentioned this pull request Nov 26, 2021
Open
33 tasks
Trott
Trott approved these changes Nov 26, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021
@nodejs-github-bot
nodejs-github-bot merged commit b3073f3 into nodejs:masterNov 26, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2021

Copy link
Copy Markdown
Collaborator

Landed in b3073f3

@targos
targos deleted the gyp-make-toolset branch November 26, 2021 07:10
@TrottTrott mentioned this pull request Nov 26, 2021
Merged
targos added a commit that referenced this pull request Nov 26, 2021
@targos
tools: update gyp-next to v0.10.1
747247b
PR-URL: #40934
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
This was referenced Nov 27, 2021
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@targos@danielleadams
tools: update gyp-next to v0.10.1
fa4aebc
PR-URL: #40934
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@targos@danielleadams
tools: update gyp-next to v0.10.1
5527e9b
PR-URL: #40934
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@TrottTrottTrott approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.gypIssues and PRs related to the GYP tool and .gyp build filesneeds-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@Qard@Trott@richardlau@BethGriggs