Skip to content

tools: consolidate ESLint dependencies - #40995

Closed
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:eslint-dedup
Closed

tools: consolidate ESLint dependencies#40995
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:eslint-dedup

Conversation

@Trott

@TrottTrott commented Nov 27, 2021

Copy link
Copy Markdown
Member

Instead of installing everything separately, put it all under ESLint and take advantage of deduplication.

Probably easiest to focus on the second/middle commit of the three.

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 27, 2021
@TrottTrott mentioned this pull request Nov 27, 2021
Merged
lpinca
lpinca approved these changes Nov 28, 2021
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Comment threadtools/update-eslint.sh Outdated

@lpincalpincaNov 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/sh -x
#!/bin/sh

Comment threadtools/update-eslint.sh Outdated

@lpincalpincaNov 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set -e
set -ex

BridgeAR
BridgeAR approved these changes Nov 28, 2021
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Trottforce-pushed the eslint-dedup branch 2 times, most recently from f29d457 to 80b300eCompareNovember 28, 2021 21:54
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2021
@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Nov 29, 2021
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2021
@Trott
tools: run ESLint update to minimize diff on subsequent update
45422db
PR-URL: nodejs#40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
tools: update ESLint update script to consolidate dependencies
6fd0a60
PR-URL: nodejs#40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
tools: consolidate ESLint dependencies
4c41fea
PR-URL: nodejs#40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
tools: remove unneeded tool in update-eslint.sh
6d8ab76
The tool to remove absolute paths from package.json files is no longer
necessary. It appears that npm no longer stores these paths, or at least
not in a way that causes the kind of churn we saw in the past.
PR-URL: nodejs#40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Nov 29, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 1998e83...6d8ab76

@TrottTrott closed this Nov 29, 2021
@Trott
Trott deleted the eslint-dedup branch November 29, 2021 22:54
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
tools: run ESLint update to minimize diff on subsequent update
8427099
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
tools: update ESLint update script to consolidate dependencies
86d5af1
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
tools: consolidate ESLint dependencies
5400b79
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
tools: remove unneeded tool in update-eslint.sh
6525226
The tool to remove absolute paths from package.json files is no longer
necessary. It appears that npm no longer stores these paths, or at least
not in a way that causes the kind of churn we saw in the past.
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 14, 2021
Merged
@danielleadams

danielleadams commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

@Trott Looks like this one will be dependent on #41770, so marking as backport-blocked for now.

danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: run ESLint update to minimize diff on subsequent update
0ed4775
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: update ESLint update script to consolidate dependencies
83f9468
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: consolidate ESLint dependencies
017cdcd
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: remove unneeded tool in update-eslint.sh
e5cccdf
The tool to remove absolute paths from package.json files is no longer
necessary. It appears that npm no longer stores these paths, or at least
not in a way that causes the kind of churn we saw in the past.
PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@danielleadams@jasnell@lpinca@tniessen@BridgeAR@nodejs-github-bot