doc: update Abstract Equality Comparison text in assert.md by Trott · Pull Request #41375 · nodejs/node

Trott · 2022-01-02T06:58:44Z

~~Update~~ Remove link to ECMAScript specification
Edit surprising-results material
Other minor edits

* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits

… assert.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

tniessen

I am ∓0 on removing the term and link. It might be easier for readers to understand why the operator is important and how it differs from === if there was a link to the spec or to MDN or a term they could look up.

Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>

Trott · 2022-01-02T19:31:07Z

I am ∓0 on removing the term and link. It might be easier for readers to understand why the operator is important and how it differs from === if there was a link to the spec or to MDN or a term they could look up.

We could use the relevant MDN link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Equality

nodejs-github-bot · 2022-01-05T20:35:03Z

Landed in 51a28c0

nodejs-github-bot · 2022-01-05T20:35:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/41375
✔ Done loading data for nodejs/node/pull/41375
----------------------------------- PR info ------------------------------------
Title doc: update Abstract Equality Comparison text in assert.md (#41375)
Author Rich Trott (@Trott)
Branch Trott:abstract -> nodejs:master
Labels assert, doc, commit-queue-squash
Commits 9
- doc: update Abstract Equality Comparison text in assert.md
- fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! fixup! doc: update Abstract Equality Comparison text in…
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
Committers 2
- Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT
✔ Approvals: 3
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193
⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1660097913

nodejs-github-bot · 2022-01-05T20:36:06Z

Commit Queue failed

- Loading data for nodejs/node/pull/41375
✔ Done loading data for nodejs/node/pull/41375
----------------------------------- PR info ------------------------------------
Title doc: update Abstract Equality Comparison text in assert.md (#41375)
Author Rich Trott (@Trott)
Branch Trott:abstract -> nodejs:master
Labels assert, doc, commit-queue-failed, commit-queue-squash
Commits 9
- doc: update Abstract Equality Comparison text in assert.md
- fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! fixup! doc: update Abstract Equality Comparison text in…
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
Committers 2
- Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT
✔ Approvals: 3
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193
⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1660166904

nodejs-github-bot · 2022-01-05T20:36:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/41375
✔ Done loading data for nodejs/node/pull/41375
----------------------------------- PR info ------------------------------------
Title doc: update Abstract Equality Comparison text in assert.md (#41375)
Author Rich Trott (@Trott)
Branch Trott:abstract -> nodejs:master
Labels assert, doc, commit-queue-failed, commit-queue-squash
Commits 9
- doc: update Abstract Equality Comparison text in assert.md
- fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! doc: update Abstract Equality Comparison text in assert.md
- fixup! fixup! fixup! doc: update Abstract Equality Comparison text in…
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
- Update doc/api/assert.md
Committers 2
- Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41375
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT
✔ Approvals: 3
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193
⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1660206628

Refs: nodejs#41375 (comment)

Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits PR-URL: #41375 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits PR-URL: #41375 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 2, 2022

benjamingr approved these changes Jan 2, 2022
View reviewed changes

aduh95 reviewed Jan 2, 2022
View reviewed changes

Comment threaddoc/api/assert.md Outdated

Trott force-pushed the abstract branch from b2c7bad to 4d245cfCompare January 2, 2022 16:07

Trott added 2 commits January 2, 2022 08:08

doc: update Abstract Equality Comparison text in assert.md
044a68f
* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits

fixup! doc: update Abstract Equality Comparison text in assert.md
9ba2345

Trott force-pushed the abstract branch from 4d245cf to 9ba2345Compare January 2, 2022 16:09

Trott added 2 commits January 2, 2022 08:10

fixup! fixup! doc: update Abstract Equality Comparison text in assert.md
8e24278

fixup! fixup! fixup! doc: update Abstract Equality Comparison text in…
37a8f8f
… assert.md

aduh95 approved these changes Jan 2, 2022
View reviewed changes

Comment threaddoc/api/assert.md Outdated

Update doc/api/assert.md
0e89837
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 2, 2022

tniessen reviewed Jan 2, 2022
View reviewed changes

Comment threaddoc/api/assert.md Outdated
Comment threaddoc/api/assert.md Outdated
Comment threaddoc/api/assert.md Outdated
Comment threaddoc/api/assert.md Outdated

Trottand others added 4 commits January 2, 2022 11:29

Update doc/api/assert.md
2e953a3
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>

Update doc/api/assert.md
1b75578
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>

Update doc/api/assert.md
f1a8722
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>

Update doc/api/assert.md
6a08b00
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>

lpinca approved these changes Jan 3, 2022
View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022

nodejs-github-bot merged commit 51a28c0 into nodejs:masterJan 5, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 5, 2022

Trott deleted the abstract branch January 5, 2022 21:28

Trott added a commit to Trott/io.js that referenced this pull request Jan 5, 2022
doc: add reference for == and != operators
36638a9
Refs: nodejs#41375 (comment)

Trott mentioned this pull request Jan 5, 2022
doc: add reference for == and != operators #41413
Merged

targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged

danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged

Navigation Menu

Uh oh!

Uh oh!

doc: update Abstract Equality Comparison text in assert.md - #41375

doc: update Abstract Equality Comparison text in assert.md#41375
nodejs-github-bot merged 9 commits into
nodejs:masterfrom
Trott:abstract

Trott commented Jan 2, 2022•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

tniessen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Trott commented Jan 2, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

Trott commented Jan 2, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Trott commented Jan 2, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

nodejs-github-bot commented Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Trott commented Jan 2, 2022•
edited
Loading