Skip to content

doc: add reference for == and != operators - #41413

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:equality
Jan 8, 2022
Merged

doc: add reference for == and != operators#41413
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:equality

Conversation

@Trott

@TrottTrott commented Jan 5, 2022

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 5, 2022
Comment threaddoc/api/assert.md Outdated
@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 5, 2022

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but be aware that strict mode still refers to the ES spec for the === operation, while the reference to the ES spec for the == operation was removed in the previous PR.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2022
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1744836 into nodejs:masterJan 8, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 1744836

@Trott
Trott deleted the equality branch January 8, 2022 04:32
targos pushed a commit that referenced this pull request Jan 14, 2022
Refs: #41375 (comment)
PR-URL: #41413
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #41375 (comment)
PR-URL: #41413
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@apapirovski@tniessen@VoltrexKeyva