You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
About #43018 (review), I hope we can discuss here. unwatch(index), not an expression, is implemented internally but undocumented anywhere. Should I add the doc to node help along with the debugger doc or leave it undocumented in terms of internal use only?
However, the current watch(expr) accepts numeric as well as string expression, which makes the difference index and expr ambiguous.
So I think string validation for watch(expr) is required (#42913).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debuggerIssues and PRs related to the debugger subsystem.docIssues and PRs related to the documentations.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unwatchcommand ofnode inspectsupports to remove specific index element.node/lib/internal/debugger/inspect_repl.js
Lines 1030 to 1038 in 8d0f49c