debugger: improve validations and documents for watch and unwatch by Dailyscat · Pull Request #46947 · nodejs/node

Dailyscat · 2023-03-04T10:43:28Z

I combined what was reflected in each PR.

add information on unwatch(index) command
add string validation for watch command

nodejs-github-bot · 2023-03-05T23:52:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50217/

nodejs-github-bot · 2023-03-07T09:01:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/46947
✔ Done loading data for nodejs/node/pull/46947
----------------------------------- PR info ------------------------------------
Title debugger: Add string validation for watch, add information on unwatch(index) command (#46947)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Dailyscat:add-string-validation-for-watch -> nodejs:main
Labels author ready, needs-ci, debugger, commit-queue-squash
Commits 4
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option
Committers 1
- eungyu.lee PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno --------------------------------------------------------------------------------
ℹ This PR was created on Sat, 04 Mar 2023 10:43:28 GMT
✔ Approvals: 1
✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593
✖ This PR needs to wait 97 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-03-05T23:52:56Z: https://ci.nodejs.org/job/node-test-pull-request/50217/
- Querying data for job/node-test-pull-request/50217/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4352354485

cola119 · 2023-03-09T01:23:26Z

@Dailyscat Can you squash all commits and update the initial commit message to a more relevant one?

- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option

nodejs-github-bot · 2023-03-11T01:09:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50314/

nodejs-github-bot · 2023-03-11T09:46:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50319/

nodejs-github-bot · 2023-03-12T01:30:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50326/

nodejs-github-bot · 2023-03-12T04:38:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50329/

nodejs-github-bot · 2023-03-12T11:58:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50331/

nodejs-github-bot · 2023-03-12T13:41:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50334/

nodejs-github-bot · 2023-03-13T02:22:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50343/

nodejs-github-bot · 2023-03-13T03:51:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/46947
✔ Done loading data for nodejs/node/pull/46947
----------------------------------- PR info ------------------------------------
Title debugger: improve validations and documents for watch and unwatch (#46947)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Dailyscat:add-string-validation-for-watch -> nodejs:main
Labels author ready, needs-ci, debugger
Commits 1
- debugger: improve validations and documents for watch and unwatch
Committers 1
- eungyu.lee PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - debugger: improve validations and documents for watch and unwatch
ℹ This PR was created on Sat, 04 Mar 2023 10:43:28 GMT
✔ Approvals: 1
✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-03-13T02:22:26Z: https://ci.nodejs.org/job/node-test-pull-request/50343/
- Querying data for job/node-test-pull-request/50343/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4401209251

nodejs-github-bot · 2023-03-13T04:29:55Z

Landed in f8bf498

- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option PR-URL: #46947 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Mar 4, 2023

cola119 changed the title ~~debugger, doc: Add string validation for watch, add information on unwatch(index) command~~debugger: Add string validation for watch, add information on unwatch(index) commandMar 5, 2023

cola119 approved these changes Mar 5, 2023
View reviewed changes

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 7, 2023

cola119 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 7, 2023

Dailyscat force-pushed the add-string-validation-for-watch branch from f52a538 to 4b84bc5Compare March 10, 2023 01:59

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023

Dailyscat force-pushed the add-string-validation-for-watch branch from 4b84bc5 to b32bffdCompare March 10, 2023 03:53

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023

debugger: improve validations and documents for watch and unwatch
28de121
- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option

Dailyscat force-pushed the add-string-validation-for-watch branch from b32bffd to 28de121Compare March 10, 2023 03:57

github-actionsBot mentioned this pull request Mar 11, 2023
CI Reliability 2023-03-11 nodejs/reliability#520
Open
22 tasks

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023

github-actionsBot mentioned this pull request Mar 12, 2023
CI Reliability 2023-03-12 nodejs/reliability#521
Open
20 tasks

cola119 changed the title ~~debugger: Add string validation for watch, add information on unwatch(index) command~~debugger: improve validations and documents for watch and unwatchMar 12, 2023

github-actionsBot mentioned this pull request Mar 13, 2023
CI Reliability 2023-03-13 nodejs/reliability#522
Open
20 tasks

cola119 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 13, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 13, 2023

cola119 approved these changes Mar 13, 2023
View reviewed changes

cola119 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 13, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023

nodejs-github-bot merged commit f8bf498 into nodejs:mainMar 13, 2023

github-actionsBot mentioned this pull request Mar 14, 2023
CI Reliability 2023-03-14 nodejs/reliability#523
Open
24 tasks

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

This was referenced Mar 15, 2023
CI Reliability 2023-03-15 nodejs/reliability#524
Open
CI Reliability 2023-03-16 nodejs/reliability#525
Open
CI Reliability 2023-03-17 nodejs/reliability#526
Open
CI Reliability 2023-03-18 nodejs/reliability#527
Open

danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged

Navigation Menu

Uh oh!

Uh oh!

debugger: improve validations and documents for watch and unwatch - #46947

debugger: improve validations and documents for watch and unwatch#46947
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Dailyscat:add-string-validation-for-watch

Dailyscat commented Mar 4, 2023

Uh oh!

nodejs-github-bot commented Mar 5, 2023

Uh oh!

nodejs-github-bot commented Mar 7, 2023

Uh oh!

cola119 commented Mar 9, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Dailyscat commented Mar 4, 2023

Uh oh!

nodejs-github-bot commented Mar 5, 2023

Uh oh!

nodejs-github-bot commented Mar 7, 2023

Uh oh!

cola119 commented Mar 9, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants