test: refactor to top-level await by meekdenzo · Pull Request #43500 · nodejs/node

meekdenzo · 2022-06-20T03:53:33Z

This refactors to top-level await.

nodejs-github-bot · 2022-06-20T18:28:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44765/

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2022-06-23T15:17:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44821/

nodejs-github-bot · 2022-06-23T17:26:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44823/

nodejs-github-bot · 2022-06-23T18:16:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44825/

nodejs-github-bot · 2022-06-23T19:14:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44826/

nodejs-github-bot · 2022-06-23T20:05:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44828/

nodejs-github-bot · 2022-06-23T20:52:07Z

Landed in 3507b3f

PR-URL: #43500 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs/node#43500

* chore: bump node in DEPS to v16.17.0 * chore: fixup asar patch * lib: use null-prototype objects for property descriptors nodejs/node#43270 * src: make SecureContext fields private nodejs/node#43173 * crypto: remove Node.js-specific webcrypto extensions nodejs/node#43310 * test: refactor to top-level await nodejs/node#43500 * deps: cherry-pick two libuv fixesnodejs/node#43950 * src: slim down env-inl.h nodejs/node#43745 * util: add AggregateError.prototype.errors to inspect output nodejs/node#43646 * esm: improve performance & tidy tests nodejs/node#43784 * src: NodeArrayBufferAllocator delegates to v8's allocator nodejs/node#43594 * chore: update patch indices * chore: update filenames * src: refactor IsSupportedAuthenticatedMode nodejs/node#42368 * src: add --openssl-legacy-provider option nodejs/node#40478 * lib,src: add source map support for global eval nodejs/node#43428 * trace_events: trace net connect event nodejs/node#43903 * deps: update ICU to 71.1 nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 * lib: give names to promisified exists() and question() nodejs/node#43218 * crypto: add CFRG curves to Web Crypto API nodejs/node#42507 * src: fix memory leak for v8.serialize nodejs/node#42695 This test does not work for Electron as they do not use V8's ArrayBufferAllocator. * buffer: fix atob input validation nodejs/node#42539 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

PR-URL: nodejs/node#43500 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

* chore: bump node in DEPS to v16.17.0 * chore: fixup asar patch * lib: use null-prototype objects for property descriptors nodejs/node#43270 * src: make SecureContext fields private nodejs/node#43173 * crypto: remove Node.js-specific webcrypto extensions nodejs/node#43310 * test: refactor to top-level await nodejs/node#43500 * deps: cherry-pick two libuv fixesnodejs/node#43950 * src: slim down env-inl.h nodejs/node#43745 * util: add AggregateError.prototype.errors to inspect output nodejs/node#43646 * esm: improve performance & tidy tests nodejs/node#43784 * src: NodeArrayBufferAllocator delegates to v8's allocator nodejs/node#43594 * chore: update patch indices * chore: update filenames * src: refactor IsSupportedAuthenticatedMode nodejs/node#42368 * src: add --openssl-legacy-provider option nodejs/node#40478 * lib,src: add source map support for global eval nodejs/node#43428 * trace_events: trace net connect event nodejs/node#43903 * deps: update ICU to 71.1 nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 * lib: give names to promisified exists() and question() nodejs/node#43218 * crypto: add CFRG curves to Web Crypto API nodejs/node#42507 * src: fix memory leak for v8.serialize nodejs/node#42695 This test does not work for Electron as they do not use V8's ArrayBufferAllocator. * buffer: fix atob input validation nodejs/node#42539 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

test: refactor to top-level await
069a67e

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 20, 2022

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022

Trott requested a review from aduh95 June 20, 2022 20:08

Trott approved these changes Jun 20, 2022
View reviewed changes

aduh95 approved these changes Jun 20, 2022
View reviewed changes

Comment threadtest/parallel/test-debugger-address.mjs Outdated

lpinca approved these changes Jun 22, 2022
View reviewed changes

Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 23, 2022

Update test/parallel/test-debugger-address.mjs
b6da998
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

meekdenzo commented Jun 23, 2022
View reviewed changes

Comment threadtest/parallel/test-debugger-address.mjs Outdated

Update test/parallel/test-debugger-address.mjs
a36b9a2

Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 23, 2022

aduh95 approved these changes Jun 23, 2022
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2022

Trott approved these changes Jun 23, 2022
View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2022

nodejs-github-bot merged commit 3507b3f into nodejs:mainJun 23, 2022

github-actionsBot mentioned this pull request Jun 24, 2022
CI Reliability 2022-06-24 nodejs/reliability#310
Open
32 tasks

GulajavaMinistudio mentioned this pull request Jun 24, 2022
Create a new pull request by comparing changes across javascript-indonesias/node#634
Merged

This was referenced Jun 25, 2022
CI Reliability 2022-06-25 nodejs/reliability#311
Open
CI Reliability 2022-06-26 nodejs/reliability#312
Open
CI Reliability 2022-06-27 nodejs/reliability#313
Open
CI Reliability 2022-06-28 nodejs/reliability#314
Open

targos pushed a commit that referenced this pull request Jul 12, 2022
test: refactor to top-level await
bd91337
PR-URL: #43500 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged

targos pushed a commit that referenced this pull request Jul 20, 2022
test: refactor to top-level await
04b8d22
PR-URL: #43500 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request Jul 31, 2022
test: refactor to top-level await
93de96f
PR-URL: #43500 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged

codebytere added a commit to electron/electron that referenced this pull request Aug 22, 2022
test: refactor to top-level await
ae17368
nodejs/node#43500

codebytere added a commit to electron/electron that referenced this pull request Aug 24, 2022
test: refactor to top-level await
dbcd98f
nodejs/node#43500

codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022
test: refactor to top-level await
2dae231
nodejs/node#43500

Navigation Menu

Uh oh!

Uh oh!

test: refactor to top-level await - #43500

test: refactor to top-level await#43500
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
meekdenzo:test-debugger-address-modify

meekdenzo commented Jun 20, 2022

Uh oh!

nodejs-github-bot commented Jun 20, 2022

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

meekdenzo commented Jun 20, 2022

Uh oh!

nodejs-github-bot commented Jun 20, 2022

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

nodejs-github-bot commented Jun 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants