Skip to content

util: add AggregateError.prototype.errors to inspect output - #43646

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
LiviaMedeiros:inspect-agriculture-error
Jul 9, 2022
Merged

util: add AggregateError.prototype.errors to inspect output#43646
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
LiviaMedeiros:inspect-agriculture-error

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Jul 1, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #43645

Old:

>(()=>{thrownewAggregateError([newTypeError('blep'),newRangeError('blop')],'gwak')})()Uncaught AggregateError: gwakat REPL1:1:13

New:

>(()=>{thrownewAggregateError([newTypeError('blep'),newRangeError('blop')],'gwak')})()Uncaught AggregateError: gwakat REPL1:1:13{[errors]: [TypeError: blepatREPL1:1:33atREPL1:1:89atScript.runInThisContext(node:vm:130:12)atREPLServer.defaultEval(node:repl:572:29)atbound(node:domain:426:15)atREPLServer.runBound[aseval](node:domain:437:12)atREPLServer.onLine(node:repl:902:10)atREPLServer.emit(node:events:549:35)atREPLServer.emit(node:domain:482:12)at[_onLine][as_onLine](node:internal/readline/interface:425:12),RangeError: blopatREPL1:1:56atREPL1:1:89atScript.runInThisContext(node:vm:130:12)atREPLServer.defaultEval(node:repl:572:29)atbound(node:domain:426:15)atREPLServer.runBound[aseval](node:domain:437:12)atREPLServer.onLine(node:repl:902:10)atREPLServer.emit(node:events:549:35)atREPLServer.emit(node:domain:482:12)at[_onLine][as_onLine](node:internal/readline/interface:425:12)]}

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jul 1, 2022
aduh95
aduh95 reviewed Jul 4, 2022
View reviewed changes
Comment threadlib/internal/errors.js Outdated
devsnek
devsnek reviewed Jul 4, 2022
View reviewed changes
Comment threadlib/internal/errors.js Outdated
@LiviaMedeiros
LiviaMedeiros marked this pull request as ready for review July 5, 2022 11:00
@LiviaMedeirosLiviaMedeiros changed the title errors: add custom inspector for AggregateErrorerrors: add AggregateError.prototype.errors to inspect outputJul 5, 2022
BridgeAR
BridgeAR approved these changes Jul 5, 2022
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Please change the module to util.

@LiviaMedeiros
LiviaMedeirosforce-pushed the inspect-agriculture-error branch from c5ffb07 to 36b9381CompareJuly 5, 2022 12:50
@LiviaMedeirosLiviaMedeiros changed the title errors: add AggregateError.prototype.errors to inspect outpututil: add AggregateError.prototype.errors to inspect outputJul 5, 2022
aduh95
aduh95 reviewed Jul 5, 2022
View reviewed changes
Comment threadlib/internal/util/inspect.js Outdated
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45182/

@github-actionsgithub-actionsBot mentioned this pull request Jul 9, 2022
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45219/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 9, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 653cfff into nodejs:mainJul 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in 653cfff

@github-actionsgithub-actionsBot mentioned this pull request Jul 10, 2022
Open
20 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@LiviaMedeiros@targos
util: add AggregateError.prototype.errors to inspect output
5a5c4be
PR-URL: #43646Fixes: #43645
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Jul 12, 2022
Merged
@F3n67uF3n67u mentioned this pull request Jul 12, 2022
Closed
targos pushed a commit that referenced this pull request Jul 31, 2022
@LiviaMedeiros@targos
util: add AggregateError.prototype.errors to inspect output
5edfccf
PR-URL: #43646Fixes: #43645
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
codebytere added a commit to electron/electron that referenced this pull request Aug 22, 2022
@codebytere
util: add AggregateError.prototype.errors to inspect output
c137633
nodejs/node#43646
codebytere added a commit to electron/electron that referenced this pull request Aug 23, 2022
@codebytere
util: add AggregateError.prototype.errors to inspect output
3033afe
nodejs/node#43646
codebytere added a commit to electron/electron that referenced this pull request Aug 24, 2022
@codebytere
util: add AggregateError.prototype.errors to inspect output
717ed36
nodejs/node#43646
codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022
@codebytere
util: add AggregateError.prototype.errors to inspect output
9afd11e
nodejs/node#43646
jkleinsc pushed a commit to electron/electron that referenced this pull request Aug 29, 2022
@electron-roller@codebytere
chore: bump node to v16.17.0 (main) (#35350)
d0e220c
* chore: bump node in DEPS to v16.17.0
* chore: fixup asar patch
* lib: use null-prototype objects for property descriptors
nodejs/node#43270
* src: make SecureContext fields private
nodejs/node#43173
* crypto: remove Node.js-specific webcrypto extensions
nodejs/node#43310
* test: refactor to top-level await
nodejs/node#43500
* deps: cherry-pick two libuv fixesnodejs/node#43950
* src: slim down env-inl.h
nodejs/node#43745
* util: add AggregateError.prototype.errors to inspect output
nodejs/node#43646
* esm: improve performance & tidy tests
nodejs/node#43784
* src: NodeArrayBufferAllocator delegates to v8's allocator
nodejs/node#43594
* chore: update patch indices
* chore: update filenames
* src: refactor IsSupportedAuthenticatedMode
nodejs/node#42368
* src: add --openssl-legacy-provider option
nodejs/node#40478
* lib,src: add source map support for global eval
nodejs/node#43428
* trace_events: trace net connect event
nodejs/node#43903
* deps: update ICU to 71.1
nodejs/node#42655
This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
* lib: give names to promisified exists() and question()
nodejs/node#43218
* crypto: add CFRG curves to Web Crypto API
nodejs/node#42507
* src: fix memory leak for v8.serialize
nodejs/node#42695
This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.
* buffer: fix atob input validation
nodejs/node#42539
* src: fix ssize_t error from nghttp2.h
nodejs/node#44393
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@LiviaMedeiros@guangwong
util: add AggregateError.prototype.errors to inspect output
0b126a6
PR-URL: nodejs/node#43646Fixes: nodejs/node#43645
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@electron-roller@codebytere@khalwa
chore: bump node to v16.17.0 (main) (electron#35350)
a2ca4b7
* chore: bump node in DEPS to v16.17.0
* chore: fixup asar patch
* lib: use null-prototype objects for property descriptors
nodejs/node#43270
* src: make SecureContext fields private
nodejs/node#43173
* crypto: remove Node.js-specific webcrypto extensions
nodejs/node#43310
* test: refactor to top-level await
nodejs/node#43500
* deps: cherry-pick two libuv fixesnodejs/node#43950
* src: slim down env-inl.h
nodejs/node#43745
* util: add AggregateError.prototype.errors to inspect output
nodejs/node#43646
* esm: improve performance & tidy tests
nodejs/node#43784
* src: NodeArrayBufferAllocator delegates to v8's allocator
nodejs/node#43594
* chore: update patch indices
* chore: update filenames
* src: refactor IsSupportedAuthenticatedMode
nodejs/node#42368
* src: add --openssl-legacy-provider option
nodejs/node#40478
* lib,src: add source map support for global eval
nodejs/node#43428
* trace_events: trace net connect event
nodejs/node#43903
* deps: update ICU to 71.1
nodejs/node#42655
This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
* lib: give names to promisified exists() and question()
nodejs/node#43218
* crypto: add CFRG curves to Web Crypto API
nodejs/node#42507
* src: fix memory leak for v8.serialize
nodejs/node#42695
This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.
* buffer: fix atob input validation
nodejs/node#42539
* src: fix ssize_t error from nghttp2.h
nodejs/node#44393
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.errorsIssues and PRs related to JavaScript errors originated in Node.js core.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inspect: print individual AggregateError.errors

5 participants

@LiviaMedeiros@nodejs-github-bot@devsnek@BridgeAR@aduh95